Skip to content

A
angle
Commit 0c3d0b21 by Shahbaz Youssefi Committed by Commit Bot
Options

Fix texture buffer validation w.r.t to non-existing buffer

Bug: angleproject:3573 Test: dEQP.KHR_GLES31/core_texture_buffer_texture_buffer_errors Change-Id: I031abd94d6c06e539a2a89a82f2af604a6f3b5b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533493Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
parent 6a1fb047
Showing with 7 additions and 0 deletions
src/libANGLE/validationES31.cpp
...@@ -2307,6 +2307,13 @@ bool ValidateTexBufferRangeBase(const Context *context, ...@@ -2307,6 +2307,13 @@ bool ValidateTexBufferRangeBase(const Context *context,
return false; return false;
} }
const Buffer *buffer = context->getBuffer(bufferPacked); const Buffer *buffer = context->getBuffer(bufferPacked);
if (!buffer)
{
context->validationError(GL_INVALID_OPERATION, kBufferNotBound);
return false;
}
if (offset + size > buffer->getSize()) if (offset + size > buffer->getSize())
{ {
context->validationError(GL_INVALID_VALUE, kTextureBufferSizeOffset); context->validationError(GL_INVALID_VALUE, kTextureBufferSizeOffset);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment