FrameCapture: Handle glReadPixels with pack buffer

Test: Capture PUBG Mobile Bug: b/159238311 Bug: b/165824228 Change-Id: I3d76e0ccd641616ba971f15ed6ea280c4905fe18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2503473 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

FrameCapture: Handle glReadPixels with pack buffer
1844860f · Cody Northrop · Commit Bot · c22200d8 · 1844860f
Commit 1844860f authored Oct 27, 2020 by Cody Northrop Committed by Commit Bot Oct 28, 2020
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

capture_gles_2_0_params.cpp src/libANGLE/capture_gles_2_0_params.cpp +6 -0

No files found.
--- a/src/libANGLE/capture_gles_2_0_params.cpp
+++ b/src/libANGLE/capture_gles_2_0_params.cpp
@@ -606,6 +606,12 @@ void CaptureReadPixels_pixels(const State &glState,
                              void *pixels,
                              ParamCapture *paramCapture)
 {
+    if (glState.getTargetBuffer(gl::BufferBinding::PixelPack))
+    {
+        // If a pixel pack buffer is bound, this is an offset, not a pointer
+        paramCapture->value.voidPointerVal = pixels;
+        return;
+    }
    // Use a conservative upper bound instead of an exact size to be simple.
    static constexpr GLsizei kMaxPixelSize = 32;
    paramCapture->readBufferSizeBytes      = kMaxPixelSize * width * height;