Commit 19aac801 by Shahbaz Youssefi Committed by Commit Bot

Vulkan: Remove unnecessary endRenderPass calls.

In both onImageRead and onImageWrite, there's a call to endRenderPassAndGetCommandBuffer when necessary to record a command. There was an extraneous call to endRenderPass in both functions for no good reason. Bug: angleproject:4882 Change-Id: I8f3b18dbb3cb9a8b92dedcc603eaf44b1e485986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2323642Reviewed-by: 's avatarTim Van Patten <timvp@google.com> Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
parent 8138cbbd
...@@ -4317,8 +4317,6 @@ angle::Result ContextVk::onImageRead(VkImageAspectFlags aspectFlags, ...@@ -4317,8 +4317,6 @@ angle::Result ContextVk::onImageRead(VkImageAspectFlags aspectFlags,
{ {
ASSERT(!image->isReleasedToExternal()); ASSERT(!image->isReleasedToExternal());
ANGLE_TRY(endRenderPass());
if (image->isLayoutChangeNecessary(imageLayout)) if (image->isLayoutChangeNecessary(imageLayout))
{ {
vk::CommandBuffer *commandBuffer; vk::CommandBuffer *commandBuffer;
...@@ -4335,8 +4333,6 @@ angle::Result ContextVk::onImageWrite(VkImageAspectFlags aspectFlags, ...@@ -4335,8 +4333,6 @@ angle::Result ContextVk::onImageWrite(VkImageAspectFlags aspectFlags,
{ {
ASSERT(!image->isReleasedToExternal()); ASSERT(!image->isReleasedToExternal());
ANGLE_TRY(endRenderPass());
// Barriers are always required for image writes. // Barriers are always required for image writes.
ASSERT(image->isLayoutChangeNecessary(imageLayout)); ASSERT(image->isLayoutChangeNecessary(imageLayout));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment