Vulkan: Addition of ImageRespecificationTest

src/tests/gl_tests/StateChangeTest.cpp

@@ -4825,6 +4825,315 @@ TEST_P(SimpleStateChangeTestES3, RasterizerDiscardState)
     ASSERT_GL_NO_ERROR();
     EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
 }
+
+class ImageRespecificationTest : public ANGLETest
+{
+  protected:
+    ImageRespecificationTest()
+    {
+        setWindowWidth(128);
+        setWindowHeight(128);
+        setConfigRedBits(8);
+        setConfigGreenBits(8);
+        setConfigBlueBits(8);
+        setConfigAlphaBits(8);
+        setConfigDepthBits(24);
+    }
+
+    void testSetUp() override
+    {
+        constexpr char kVS[] = R"(precision highp float;
+attribute vec4 position;
+varying vec2 texcoord;
+
+void main()
+{
+    gl_Position = position;
+    texcoord = (position.xy * 0.5) + 0.5;
+})";
+
+        constexpr char kFS[] = R"(precision highp float;
+uniform sampler2D tex;
+varying vec2 texcoord;
+
+void main()
+{
+    gl_FragColor = texture2D(tex, texcoord);
+})";
+
+        mProgram = CompileProgram(kVS, kFS);
+        ASSERT_NE(0u, mProgram);
+
+        mTextureUniformLocation = glGetUniformLocation(mProgram, "tex");
+        ASSERT_NE(-1, mTextureUniformLocation);
+
+        glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
+        ASSERT_GL_NO_ERROR();
+    }
+
+    void testTearDown() override
+    {
+        if (mProgram != 0)
+        {
+            glDeleteProgram(mProgram);
+        }
+    }
+
+    template <typename T>
+    void init2DSourceTexture(GLenum internalFormat,
+                             GLenum dataFormat,
+                             GLenum dataType,
+                             const T *data)
+    {
+        glBindTexture(GL_TEXTURE_2D, mSourceTexture);
+        glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
+
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+
+        glBindTexture(GL_TEXTURE_2D, 0);
+    }
+
+    void attachTargetTextureToFramebuffer()
+    {
+        glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
+        glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, mTargetTexture,
+                               0);
+
+        ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
+        ASSERT_GL_NO_ERROR();
+
+        glBindFramebuffer(GL_FRAMEBUFFER, 0);
+    }
+
+    void renderToTargetTexture()
+    {
+        glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
+
+        glActiveTexture(GL_TEXTURE0);
+        glBindTexture(GL_TEXTURE_2D, mSourceTexture);
+
+        glUseProgram(mProgram);
+        glUniform1i(mTextureUniformLocation, 0);
+
+        drawQuad(mProgram, "position", 0.5f);
+        ASSERT_GL_NO_ERROR();
+
+        glBindFramebuffer(GL_FRAMEBUFFER, 0);
+        glBindTexture(GL_TEXTURE_2D, 0);
+        glUseProgram(0);
+    }
+
+    void renderToDefaultFramebuffer(GLColor *expectedData)
+    {
+        glBindFramebuffer(GL_FRAMEBUFFER, 0);
+        glUseProgram(mProgram);
+        glBindTexture(GL_TEXTURE_2D, mTargetTexture);
+        glUniform1i(mTextureUniformLocation, 0);
+
+        glClear(GL_COLOR_BUFFER_BIT);
+        drawQuad(mProgram, "position", 0.5f);
+        ASSERT_GL_NO_ERROR();
+
+        EXPECT_PIXEL_COLOR_EQ(0, 0, *expectedData);
+
+        glBindTexture(GL_TEXTURE_2D, 0);
+        glUseProgram(0);
+    }
+
+    GLuint mProgram;
+    GLint mTextureUniformLocation;
+
+    GLTexture mSourceTexture;
+    GLTexture mTargetTexture;
+
+    GLFramebuffer mFramebuffer;
+};
+
+// Verify that a swizzle on an active sampler is handled appropriately
+TEST_P(ImageRespecificationTest, Swizzle)
+{
+    // TODO: Fix FramebufferVk caching logic (http://anglebug.com/4651)
+    ANGLE_SKIP_TEST_IF(isVulkanRenderer());
+
+    GLubyte data[] = {1, 64, 128, 200};
+    GLColor expectedData(data[0], data[1], data[2], data[3]);
+
+    // Create the source and target texture
+    init2DSourceTexture(GL_RGBA8, GL_RGBA, GL_UNSIGNED_BYTE, data);
+
+    glBindTexture(GL_TEXTURE_2D, mTargetTexture);
+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
+
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+
+    glBindTexture(GL_TEXTURE_2D, 0);
+
+    // Create a framebuffer and the target texture is attached to the framebuffer.
+    attachTargetTextureToFramebuffer();
+
+    glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
+    glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
+    glClear(GL_COLOR_BUFFER_BIT);
+    glBindFramebuffer(GL_FRAMEBUFFER, 0);
+
+    // Render content of source texture to target texture
+    // This command triggers the creation of -
+    //     - draw imageviews of the texture
+    //     - VkFramebuffer object of the framebuffer
+    renderToTargetTexture();
+
+    // This swizzle operation should cause the read imageviews of the texture to be released
+    glBindTexture(GL_TEXTURE_2D, mTargetTexture);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_R, GL_RED);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_G, GL_GREEN);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_B, GL_BLUE);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_A, GL_ALPHA);
+    glBindTexture(GL_TEXTURE_2D, 0);
+
+    // Draw using the newly created read imageviews
+    renderToDefaultFramebuffer(&expectedData);
+
+    // Render content of source texture to target texture, again
+    renderToTargetTexture();
+
+    // Make sure the content rendered to target texture is correct
+    renderToDefaultFramebuffer(&expectedData);
+}
+
+// Verify that when a texture is respecified through glEGLImageTargetTexture2DOES,
+// the Framebuffer that has the texture as a color attachment is recreated before next use.
+TEST_P(ImageRespecificationTest, ImageTarget2DOESSwitch)
+{
+    // TODO: Fix FramebufferVk caching logic (http://anglebug.com/4651)
+    ANGLE_SKIP_TEST_IF(isVulkanRenderer());
+
+    // This is the specific problem on the Vulkan backend and needs some extensions
+    ANGLE_SKIP_TEST_IF(
+        !IsGLExtensionEnabled("GL_OES_EGL_image_external") ||
+        !IsEGLDisplayExtensionEnabled(getEGLWindow()->getDisplay(), "EGL_KHR_gl_texture_2D_image"));
+
+    GLubyte data[] = {1, 64, 128, 200};
+    GLColor expectedData(data[0], data[1], data[2], data[3]);
+
+    // Create the source texture
+    init2DSourceTexture(GL_RGBA8, GL_RGBA, GL_UNSIGNED_BYTE, data);
+
+    // Create the first EGL image to attach the framebuffer through the texture
+    GLTexture firstTexture;
+
+    glBindTexture(GL_TEXTURE_2D, firstTexture);
+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
+
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+
+    glBindTexture(GL_TEXTURE_2D, 0);
+
+    EGLWindow *window = getEGLWindow();
+    EGLint attribs[]  = {
+        EGL_IMAGE_PRESERVED,
+        EGL_TRUE,
+        EGL_NONE,
+    };
+    EGLImageKHR firstEGLImage =
+        eglCreateImageKHR(window->getDisplay(), window->getContext(), EGL_GL_TEXTURE_2D_KHR,
+                          reinterpret_cast<EGLClientBuffer>(firstTexture.get()), attribs);
+    ASSERT_EGL_SUCCESS();
+
+    // Create the target texture and attach it to the framebuffer
+    glBindTexture(GL_TEXTURE_2D, mTargetTexture);
+    glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, firstEGLImage);
+
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+
+    glBindTexture(GL_TEXTURE_2D, 0);
+
+    attachTargetTextureToFramebuffer();
+
+    glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
+
+    glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
+    glClear(GL_COLOR_BUFFER_BIT);
+
+    glBindFramebuffer(GL_FRAMEBUFFER, 0);
+
+    // Render content of source texture to target texture
+    // This command triggers the creation of -
+    //     - draw imageviews of the texture
+    //     - VkFramebuffer object of the framebuffer
+    renderToTargetTexture();
+
+    // Make sure the content rendered to target texture is correct
+    renderToDefaultFramebuffer(&expectedData);
+
+    // Create the second EGL image
+    GLTexture secondTexture;
+
+    glBindTexture(GL_TEXTURE_2D, secondTexture);
+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
+
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+
+    glBindTexture(GL_TEXTURE_2D, 0);
+
+    EGLImageKHR secondEGLImage =
+        eglCreateImageKHR(window->getDisplay(), window->getContext(), EGL_GL_TEXTURE_2D_KHR,
+                          reinterpret_cast<EGLClientBuffer>(secondTexture.get()), attribs);
+    ASSERT_EGL_SUCCESS();
+
+    glBindTexture(GL_TEXTURE_2D, mTargetTexture);
+    // This will release all the imageviews related to the first EGL image
+    glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, secondEGLImage);
+
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+
+    glBindTexture(GL_TEXTURE_2D, 0);
+
+    // Attach the first EGL image to the target texture again
+    glBindTexture(GL_TEXTURE_2D, mTargetTexture);
+    glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, firstEGLImage);
+
+    // This is for checking this code can deal with the problem even if both ORPHAN and
+    // COLOR_ATTACHMENT dirty bits are set.
+    GLTexture tempTexture;
+
+    glBindTexture(GL_TEXTURE_2D, tempTexture);
+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
+
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+
+    glBindTexture(GL_TEXTURE_2D, 0);
+
+    // This sets COLOR_ATTACHMENT dirty bit
+    glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
+    glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, tempTexture, 0);
+    glBindFramebuffer(GL_FRAMEBUFFER, 0);
+
+    // The released imageviews related to "secondEGLImage" will be garbage collected
+    renderToDefaultFramebuffer(&expectedData);
+
+    // Process both OPPHAN and COLOR_ATTACHMENT dirty bits
+    renderToTargetTexture();
+
+    // Make sure the content rendered to target texture is correct
+    renderToDefaultFramebuffer(&expectedData);
+
+    // Render content of source texture to target texture
+    attachTargetTextureToFramebuffer();
+    renderToTargetTexture();
+
+    // Make sure the content rendered to target texture is correct
+    renderToDefaultFramebuffer(&expectedData);
+
+    eglDestroyImageKHR(window->getDisplay(), firstEGLImage);
+    eglDestroyImageKHR(window->getDisplay(), secondEGLImage);
+}
 }  // anonymous namespace
 
 ANGLE_INSTANTIATE_TEST_ES2(StateChangeTest);
@@ -4833,6 +5142,7 @@ ANGLE_INSTANTIATE_TEST_ES2(StateChangeRenderTest);
 ANGLE_INSTANTIATE_TEST_ES3(StateChangeTestES3);
 ANGLE_INSTANTIATE_TEST_ES2(SimpleStateChangeTest);
 ANGLE_INSTANTIATE_TEST_ES3(SimpleStateChangeTestES3);
+ANGLE_INSTANTIATE_TEST_ES3(ImageRespecificationTest);
 ANGLE_INSTANTIATE_TEST_ES31(SimpleStateChangeTestES31);
 ANGLE_INSTANTIATE_TEST_ES31(SimpleStateChangeTestComputeES31);
 ANGLE_INSTANTIATE_TEST_ES31(SimpleStateChangeTestComputeES31PPO);