Change UNIMPLEMENTED to not assert by default.

It is not feasible to run dEQP against ES 3.1 on the bots without removing this assertion. Messages will still be logged and UNREACHABLE will still generate assertion failures when the behaviour is needed. This matches the behaviour of Chromium's NOTIMPLEMENTED macro. Remove the ANGLE_TEST_CONFIG macro, it was not doing anything useful anymore. BUG=angleproject:1442 Change-Id: I76376817a87e1a75ad1a938e1db1d7763e094372 Reviewed-on: https://chromium-review.googlesource.com/406928Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>

Change UNIMPLEMENTED to not assert by default.
2f6435e0 · Geoff Lang · Commit Bot · d2f0c74c · 2f6435e0 · 2f6435e0
Commit 2f6435e0 authored Nov 02, 2016 by Geoff Lang Committed by Commit Bot Nov 02, 2016
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 12 deletions

debug.h src/common/debug.h +2 -8

DisplayD3D.cpp src/libANGLE/renderer/d3d/DisplayD3D.cpp +0 -4

No files found.
--- a/src/common/debug.h
+++ b/src/common/debug.h
@@ -156,19 +156,13 @@ std::ostream &DummyStream();
 #define UNUSED_VARIABLE(variable) ((void)variable)
 // A macro to indicate unimplemented functionality
-#if defined (ANGLE_TEST_CONFIG)
-#define NOASSERT_UNIMPLEMENTED 1
-#endif
-// This will allow us to test with some automated test suites (eg dEQP) without crashing
 #ifndef NOASSERT_UNIMPLEMENTED
-#define NOASSERT_UNIMPLEMENTED 0
+#define NOASSERT_UNIMPLEMENTED 1
 #endif
 #define UNIMPLEMENTED()                                             \
    {                                                               \
-        FIXME("\t! Unimplemented: %s(%d)\n", __FUNCTION__, __LINE__); \
+        ERR("\t! Unimplemented: %s(%d)\n", __FUNCTION__, __LINE__); \
        ASSERT(NOASSERT_UNIMPLEMENTED);                             \
    }                                                               \
    ANGLE_EMPTY_STATEMENT

--- a/src/libANGLE/renderer/d3d/DisplayD3D.cpp
+++ b/src/libANGLE/renderer/d3d/DisplayD3D.cpp
@@ -29,10 +29,6 @@
 #   include "libANGLE/renderer/d3d/d3d11/Renderer11.h"
 #endif // ANGLE_ENABLE_D3D11
-#if defined (ANGLE_TEST_CONFIG)
-#   define ANGLE_DEFAULT_D3D11 1
-#endif
 #if !defined(ANGLE_DEFAULT_D3D11)
 // Enables use of the Direct3D 11 API for a default display, when available
 #   define ANGLE_DEFAULT_D3D11 1