Vulkan: Avoid INT_MAX resource limits

dEQP queries resource limits in all formats, including float. When INT_MAX is queried as float, the resulting value is INT_MAX+1 due to floating point imprecision. dEQP casts this value back to int for verification, and trips up on the resulting negative number. This change limits every ridiculously-large limit to INT_MAX/2 instead of INT_MAX. Bug: angleproject:4309 Change-Id: I11018c2c5a0c8bfb410928b0a4c34c526fab2269 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006813 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>

Vulkan: Avoid INT_MAX resource limits
4efa82ed · Shahbaz Youssefi · Commit Bot · b46e6c2f · 4efa82ed
Commit 4efa82ed authored Jan 17, 2020 by Shahbaz Youssefi Committed by Commit Bot Jan 17, 2020
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

vk_caps_utils.cpp src/libANGLE/renderer/vulkan/vk_caps_utils.cpp +3 -1

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
@@ -28,8 +28,10 @@ namespace rx
 GLint LimitToInt(const uint32_t physicalDeviceValue)
 {
+    // Limit to INT_MAX / 2 instead of INT_MAX.  If the limit is queried as float, the imprecision
+    // in floating point can cause the value to exceed INT_MAX.  This trips dEQP up.
    return std::min(physicalDeviceValue,
-                    static_cast<uint32_t>(std::numeric_limits<int32_t>::max()));
+                    static_cast<uint32_t>(std::numeric_limits<int32_t>::max() / 2));
 }
 void RendererVk::ensureCapsInitialized() const