Remove unnecessary Visit function overloading.

src/common/version.h

 #define MAJOR_VERSION 0
 #define MINOR_VERSION 0
 #define BUILD_VERSION 0
-#define BUILD_REVISION 714
+#define BUILD_REVISION 715
 
 #define STRINGIFY(x) #x
 #define MACRO_STRINGIFY(x) STRINGIFY(x)

src/compiler/DetectRecursion.cpp

@@ -64,29 +64,6 @@ DetectRecursion::~DetectRecursion()
         delete functions[i];
 }
 
-void DetectRecursion::visitSymbol(TIntermSymbol*)
-{
-}
-
-void DetectRecursion::visitConstantUnion(TIntermConstantUnion*)
-{
-}
-
-bool DetectRecursion::visitBinary(Visit, TIntermBinary*)
-{
-    return true;
-}
-
-bool DetectRecursion::visitUnary(Visit, TIntermUnary*)
-{
-    return true;
-}
-
-bool DetectRecursion::visitSelection(Visit, TIntermSelection*)
-{
-    return true;
-}
-
 bool DetectRecursion::visitAggregate(Visit visit, TIntermAggregate* node)
 {
     switch (node->getOp())
@@ -126,16 +103,6 @@ bool DetectRecursion::visitAggregate(Visit visit, TIntermAggregate* node)
     return true;
 }
 
-bool DetectRecursion::visitLoop(Visit, TIntermLoop*)
-{
-    return true;
-}
-
-bool DetectRecursion::visitBranch(Visit, TIntermBranch*)
-{
-    return true;
-}
-
 DetectRecursion::ErrorCode DetectRecursion::detectRecursion()
 {
     FunctionNode* main = findFunctionByName("main(");

src/compiler/DetectRecursion.h

@@ -24,14 +24,7 @@ public:
     DetectRecursion();
     ~DetectRecursion();
 
-    virtual void visitSymbol(TIntermSymbol*);
-    virtual void visitConstantUnion(TIntermConstantUnion*);
-    virtual bool visitBinary(Visit, TIntermBinary*);
-    virtual bool visitUnary(Visit, TIntermUnary*);
-    virtual bool visitSelection(Visit, TIntermSelection*);
     virtual bool visitAggregate(Visit, TIntermAggregate*);
-    virtual bool visitLoop(Visit, TIntermLoop*);
-    virtual bool visitBranch(Visit, TIntermBranch*);
 
     ErrorCode detectRecursion();
 

src/compiler/MapLongVariableNames.cpp

@@ -48,30 +48,6 @@ void MapLongVariableNames::visitSymbol(TIntermSymbol* symbol)
     }
 }
 
-void MapLongVariableNames::visitConstantUnion(TIntermConstantUnion*)
-{
-}
-
-bool MapLongVariableNames::visitBinary(Visit, TIntermBinary*)
-{
-    return true;
-}
-
-bool MapLongVariableNames::visitUnary(Visit, TIntermUnary*)
-{
-    return true;
-}
-
-bool MapLongVariableNames::visitSelection(Visit, TIntermSelection*)
-{
-    return true;
-}
-
-bool MapLongVariableNames::visitAggregate(Visit, TIntermAggregate*)
-{
-    return true;
-}
-
 bool MapLongVariableNames::visitLoop(Visit, TIntermLoop* node)
 {
     if (node->getInit())
@@ -79,11 +55,6 @@ bool MapLongVariableNames::visitLoop(Visit, TIntermLoop* node)
     return true;
 }
 
-bool MapLongVariableNames::visitBranch(Visit, TIntermBranch*)
-{
-    return true;
-}
-
 TString MapLongVariableNames::mapVaryingLongName(const TString& name)
 {
     TMap<TString, TString>::const_iterator it = mVaryingLongNameMap.find(name);

src/compiler/MapLongVariableNames.h

@@ -22,13 +22,7 @@ public:
     MapLongVariableNames(TMap<TString, TString>& varyingLongNameMap);
 
     virtual void visitSymbol(TIntermSymbol*);
-    virtual void visitConstantUnion(TIntermConstantUnion*);
-    virtual bool visitBinary(Visit, TIntermBinary*);
-    virtual bool visitUnary(Visit, TIntermUnary*);
-    virtual bool visitSelection(Visit, TIntermSelection*);
-    virtual bool visitAggregate(Visit, TIntermAggregate*);
     virtual bool visitLoop(Visit, TIntermLoop*);
-    virtual bool visitBranch(Visit, TIntermBranch*);
 
 private:
     TString mapVaryingLongName(const TString& name);

src/compiler/ValidateLimitations.cpp

@@ -53,13 +53,6 @@ public:
                      IsLoopIndex(symbol, mLoopStack);
         }
     }
-    virtual void visitConstantUnion(TIntermConstantUnion*) {}
-    virtual bool visitBinary(Visit, TIntermBinary*) { return true; }
-    virtual bool visitUnary(Visit, TIntermUnary*) { return true; }
-    virtual bool visitSelection(Visit, TIntermSelection*) { return true; }
-    virtual bool visitAggregate(Visit, TIntermAggregate*) { return true; }
-    virtual bool visitLoop(Visit, TIntermLoop*) { return true; }
-    virtual bool visitBranch(Visit, TIntermBranch*) { return true; }
 
 private:
     bool mValid;
@@ -94,13 +87,6 @@ public:
             }
         }
     }
-    virtual void visitConstantUnion(TIntermConstantUnion*) {}
-    virtual bool visitBinary(Visit, TIntermBinary*) { return true; }
-    virtual bool visitUnary(Visit, TIntermUnary*) { return true; }
-    virtual bool visitSelection(Visit, TIntermSelection*) { return true; }
-    virtual bool visitAggregate(Visit, TIntermAggregate*) { return true; }
-    virtual bool visitLoop(Visit, TIntermLoop*) { return true; }
-    virtual bool visitBranch(Visit, TIntermBranch*) { return true; }
 
 private:
     bool mUsesFloatLoopIndex;
@@ -117,14 +103,6 @@ ValidateLimitations::ValidateLimitations(ShShaderType shaderType,
 {
 }
 
-void ValidateLimitations::visitSymbol(TIntermSymbol*)
-{
-}
-
-void ValidateLimitations::visitConstantUnion(TIntermConstantUnion*)
-{
-}
-
 bool ValidateLimitations::visitBinary(Visit, TIntermBinary* node)
 {
     // Check if loop index is modified in the loop body.
@@ -170,11 +148,6 @@ bool ValidateLimitations::visitUnary(Visit, TIntermUnary* node)
     return true;
 }
 
-bool ValidateLimitations::visitSelection(Visit, TIntermSelection*)
-{
-    return true;
-}
-
 bool ValidateLimitations::visitAggregate(Visit, TIntermAggregate* node)
 {
     switch (node->getOp()) {
@@ -209,11 +182,6 @@ bool ValidateLimitations::visitLoop(Visit, TIntermLoop* node)
     return false;
 }
 
-bool ValidateLimitations::visitBranch(Visit, TIntermBranch*)
-{
-    return true;
-}
-
 void ValidateLimitations::error(TSourceLoc loc,
                                 const char *reason, const char* token)
 {

src/compiler/ValidateLimitations.h

@@ -25,14 +25,10 @@ public:
 
     int numErrors() const { return mNumErrors; }
 
-    virtual void visitSymbol(TIntermSymbol*);
-    virtual void visitConstantUnion(TIntermConstantUnion*);
     virtual bool visitBinary(Visit, TIntermBinary*);
     virtual bool visitUnary(Visit, TIntermUnary*);
-    virtual bool visitSelection(Visit, TIntermSelection*);
     virtual bool visitAggregate(Visit, TIntermAggregate*);
     virtual bool visitLoop(Visit, TIntermLoop*);
-    virtual bool visitBranch(Visit, TIntermBranch*);
 
 private:
     void error(TSourceLoc loc, const char *reason, const char* token);