Clean up TCompiler members and style

Some dead code and duplicate data are cleaned up from the compiler. Several parameters can be accessed directly from ShBuiltInResources instead of creating a copy in TCompiler. This also encapsulates some TCompiler member functions as private and changes the remaining unprefixed TCompiler member variable names to start with the m prefix. BUG=angleproject:2068 TEST=angle_unittests Change-Id: I6690aaf538b17e0f45460660272a21f82f1808a0 Reviewed-on: https://chromium-review.googlesource.com/c/1267503Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Clean up TCompiler members and style
6f591c97 · Olli Etuaho · Commit Bot · 6d765b07 · 6f591c97 · 6f591c97
Commit 6f591c97 authored Sep 21, 2018 by Olli Etuaho Committed by Commit Bot Oct 08, 2018
4 changed files
--- a/src/compiler/translator/Compiler.cpp
+++ b/src/compiler/translator/Compiler.cpp
--- a/src/compiler/translator/Compiler.h
+++ b/src/compiler/translator/Compiler.h
--- a/src/compiler/translator/TranslatorGLSL.cpp
+++ b/src/compiler/translator/TranslatorGLSL.cpp
@@ -141,7 +141,7 @@ void TranslatorGLSL::translate(TIntermBlock *root,
        bool hasGLSecondaryFragColor = false;
        bool hasGLSecondaryFragData  = false;
-        for (const auto &outputVar : outputVariables)
+        for (const auto &outputVar : mOutputVariables)
        {
            if (declareGLFragmentOutputs)
            {

--- a/src/compiler/translator/TranslatorVulkan.cpp
+++ b/src/compiler/translator/TranslatorVulkan.cpp
@@ -686,7 +686,7 @@ void TranslatorVulkan::translate(TIntermBlock *root,
        bool usesFragCoord  = false;
        // Search for the gl_PointCoord usage, if its used, we need to flip the y coordinate.
-        for (const Varying &inputVarying : inputVaryings)
+        for (const Varying &inputVarying : mInputVaryings)
        {
            if (!inputVarying.isBuiltIn())
            {
@@ -712,7 +712,7 @@ void TranslatorVulkan::translate(TIntermBlock *root,
        bool hasGLFragColor = false;
        bool hasGLFragData  = false;
-        for (const OutputVariable &outputVar : outputVariables)
+        for (const OutputVariable &outputVar : mOutputVariables)
        {
            if (outputVar.name == "gl_FragColor")
            {