Commit 8cbd321c by Cody Northrop Committed by Commit Bot

Android: Clean up the ANGLE APK

* Rename the APK package name to reflect that it is from Chromium build. * Rename the application to reflect it is no longer used on Android system image. * Remove code supporting multiple APKs, since we only have one now. * Remove the placeholder icon, which is no longer needed. * Remove the ANGLE_FOR_ANDROID intent, since this APK is not built in. * Remove the java code since since it was only in support of the intent. * Remove most apps from the rules file. Bug: angleproject:3396 Change-Id: Ic6a2fd03e5686026ab4650fc0c25adb298af03c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1579389Reviewed-by: 's avatarTim Van Patten <timvp@google.com> Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
parent c9a9cfcc
...@@ -1099,22 +1099,15 @@ if (!is_component_build && is_android && symbol_level != 0) { ...@@ -1099,22 +1099,15 @@ if (!is_component_build && is_android && symbol_level != 0) {
if (!is_component_build && is_android && if (!is_component_build && is_android &&
current_toolchain == default_toolchain) { current_toolchain == default_toolchain) {
# Package ANGLE libraries for pre-installed system image # Package ANGLE libraries
angle_apk("aosp_apk") { angle_apk("angle_chromium_apk") {
package_name = "com.android.angle" package_name = "com.chromium.angle"
apk_name = "AngleLibraries" apk_name = "AngleLibraries"
} }
group("angle_apks") { group("angle_apks") {
deps = [ deps = [
":aosp_apk", ":angle_chromium_apk",
]
}
# Include a temporary target until we update builders to use angle_apks
group("angle_apk") {
deps = [
":angle_apks",
] ]
} }
} }
...@@ -7,29 +7,14 @@ ...@@ -7,29 +7,14 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android" <manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
package="{{manifest_package|default('com.android.angle')}}"> package="{{manifest_package|default('com.chromium.angle')}}">
<uses-sdk android:minSdkVersion="26" <uses-sdk android:minSdkVersion="26"
android:targetSdkVersion="28"> android:targetSdkVersion="28">
</uses-sdk> </uses-sdk>
<application android:label="Android System Angle" <application android:label="Angle for Android"
android:icon="@{{manifest_package|default('com.android.angle')}}:drawable/icon"
android:extractNativeLibs="false" android:extractNativeLibs="false"
android:multiArch="true"> android:multiArch="true">
<activity android:name=".MainActivity">
<intent-filter>
<action android:name="android.intent.action.MAIN"/>
<category android:name="android.intent.category.INFO"/>
</intent-filter>
<!-- Indicate that this PKG is ANGLE. -->
<intent-filter android:priority="1">
<action android:name="android.app.action.ANGLE_FOR_ANDROID" />
<category android:name="android.intent.category.DEFAULT" />
</intent-filter>
</activity>
</application> </application>
</manifest> </manifest>
...@@ -30,11 +30,6 @@ template("angle_apk") { ...@@ -30,11 +30,6 @@ template("angle_apk") {
variables = [ "manifest_package=${invoker.package_name}" ] variables = [ "manifest_package=${invoker.package_name}" ]
} }
android_resources("${invoker.package_name}_resources") {
resource_dirs = [ "android/res" ]
custom_package = "${invoker.package_name}"
}
android_assets("${invoker.package_name}_assets") { android_assets("${invoker.package_name}_assets") {
disable_compression = true disable_compression = true
sources = [ sources = [
...@@ -48,7 +43,6 @@ template("angle_apk") { ...@@ -48,7 +43,6 @@ template("angle_apk") {
android_manifest_dep = ":$manifest_target_name" android_manifest_dep = ":$manifest_target_name"
deps = [ deps = [
":${invoker.package_name}_assets", ":${invoker.package_name}_assets",
":${invoker.package_name}_resources",
] ]
if (symbol_level != 0) { if (symbol_level != 0) {
deps += [ ":compressed_symbols" ] deps += [ ":compressed_symbols" ]
......
/*
* Copyright 2018 The ANGLE Project Authors. All rights reserved.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
package com.android.angle;
import android.app.Activity;
import android.os.Bundle;
public class MainActivity extends Activity
{
@Override
protected void onCreate(Bundle savedInstanceState)
{
super.onCreate(savedInstanceState);
}
}
...@@ -9,13 +9,7 @@ ...@@ -9,13 +9,7 @@
"UseANGLE":true, "UseANGLE":true,
"Applications":[ "Applications":[
{ {
"AppName":"com.android.angle" "AppName":"com.chromium.angle"
},
{
"AppName":"com.google.android.apps.internal.cubey"
},
{
"AppName":"com.android.gl2jni"
} }
], ],
"Devices":[ "Devices":[
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment