Lexer does not need to handle unknown-char case.

It is handled by the preprocessor. Added an assert. TEST=WebGL conformance tests. TBR=kbr@chromium.org Review URL: https://codereview.appspot.com/8653052 git-svn-id: https://angleproject.googlecode.com/svn/trunk@2194 736b8ea6-26fd-11df-bfd4-992fa37f6226

Lexer does not need to handle unknown-char case.
90613190 · alokp@chromium.org · 8e578842 · 90613190 · 90613190
Commit 90613190 authored Apr 26, 2013 by alokp@chromium.org
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 8 deletions

glslang.l src/compiler/glslang.l +1 -5

glslang_lex.cpp src/compiler/glslang_lex.cpp +1 -3

No files found.
--- a/src/compiler/glslang.l
+++ b/src/compiler/glslang.l
@@ -69,10 +69,6 @@ O           [0-7]

 %%

-%{
-    TParseContext* context = yyextra;
-%}
-
 "invariant"    { return INVARIANT; }
 "highp"        { return HIGH_PRECISION; }
 "mediump"      { return MEDIUM_PRECISION; }
@@ -255,7 +251,7 @@ O           [0-7]

 [ \t\v\n\f\r] { }
 <*><<EOF>>    { yyterminate(); }
-<*>.            { context->warning(yylineno, "Unknown char", yytext, ""); return 0; }
+<*>.          { assert(false); return 0; }

 %%


--- a/src/compiler/glslang_lex.cpp
+++ b/src/compiler/glslang_lex.cpp
@@ -1038,8 +1038,6 @@ YY_DECL
 	register int yy_act;
    struct yyguts_t * yyg = (struct yyguts_t*)yyscanner;

-    TParseContext* context = yyextra;
-
    yylval = yylval_param;

 	if ( !yyg->yy_init )
@@ -1733,7 +1731,7 @@ case YY_STATE_EOF(FIELDS):
 	YY_BREAK
 case 148:
 YY_RULE_SETUP
-{ context->warning(yylineno, "Unknown char", yytext, ""); return 0; }
+{ assert(false); return 0; }
 	YY_BREAK
 case 149:
 YY_RULE_SETUP