Capture/Replay: Minor fixes for MEC

Detected when recapturing Temple Run and Candy Crush. Each of these apps has updated recently. Test: angle_perftests --gtest_filter="*Trace*" Bug: angleproject:4845 Change-Id: Id0e8d362661d97d7b8e60b3afb0a3a989b6a6771 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441850Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>

Capture/Replay: Minor fixes for MEC
b390d8b0 · Cody Northrop · Commit Bot · 64eb64a0 · b390d8b0 · b390d8b0
Commit b390d8b0 authored Sep 30, 2020 by Cody Northrop Committed by Commit Bot Oct 01, 2020
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

FrameCapture.cpp src/libANGLE/FrameCapture.cpp +1 -1

capture_gles_2_0_params.cpp src/libANGLE/capture_gles_2_0_params.cpp +1 -4

No files found.
--- a/src/libANGLE/FrameCapture.cpp
+++ b/src/libANGLE/FrameCapture.cpp
@@ -1938,7 +1938,7 @@ void CaptureVertexArrayData(std::vector<CallCapture> *setupCalls,
        {
            // Each attribute can pull from a separate buffer, so check the binding
            gl::Buffer *buffer = binding.getBuffer().get();
-            if (buffer != replayState->getArrayBuffer())
+            if (buffer && buffer != replayState->getArrayBuffer())
            {
                replayState->setBufferBinding(context, gl::BufferBinding::Array, buffer);


--- a/src/libANGLE/capture_gles_2_0_params.cpp
+++ b/src/libANGLE/capture_gles_2_0_params.cpp
@@ -664,10 +664,7 @@ void CaptureShaderSource_length(const State &glState,
    if (!length)
        return;

-    for (GLsizei index = 0; index < count; ++index)
-    {
-        CaptureMemory(&length[index], sizeof(GLint), paramCapture);
-    }
+    CaptureMemory(length, count * sizeof(GLint), paramCapture);
 }

 void CaptureTexImage2D_pixels(const State &glState,