Restricted the length of identifiers (including #define directive) to 256, as…

src/compiler/preprocessor/new/DirectiveParser.cpp

@@ -347,6 +347,12 @@ void DirectiveParser::parseDefine(Token* token)
                              token->location, token->text);
         return;
     }
+    if (token->text.size() > Token::kMaxIdentifierLength)
+    {
+        mDiagnostics->report(Diagnostics::IDENTIFIER_OVERFLOW,
+                             token->location, token->text);
+        return;
+    }
 
     Macro macro;
     macro.type = Macro::kTypeObj;

src/compiler/preprocessor/new/Preprocessor.cpp

@@ -125,14 +125,13 @@ void Preprocessor::lex(Token* token)
           }
           case Token::IDENTIFIER:
           {
-            static const int kMaxIdentifierLength = 256;
-            if (token->text.size() > kMaxIdentifierLength)
+            if (token->text.size() > Token::kMaxIdentifierLength)
             {
                 // Do not mark the token as invalid.
                 // Just emit the diagnostic and clamp string length.
                 mImpl->diagnostics->report(Diagnostics::IDENTIFIER_OVERFLOW,
                                            token->location, token->text);
-                token->text.erase(kMaxIdentifierLength);
+                token->text.erase(Token::kMaxIdentifierLength);
             }
             validToken = true;
             break;

src/compiler/preprocessor/new/Token.cpp

@@ -31,6 +31,10 @@ static bool atoi_t(const std::string& str, IntType* value)
 namespace pp
 {
 
+// TODO(alokp): This should be specified by preprocessor client,
+// i.e., the compiler.
+const size_t Token::kMaxIdentifierLength = 256;
+
 void Token::reset()
 {
     type = 0;

src/compiler/preprocessor/new/Token.h

@@ -61,6 +61,7 @@ struct Token
         HAS_LEADING_SPACE  = 1 << 1,
         EXPANSION_DISABLED = 1 << 2
     };
+    static const size_t kMaxIdentifierLength;
 
     Token() : type(0), flags(0) { }