dontInitializeUninitializedLocals on Qualcomm only

SH_INITIALIZE_UNINITIALIZED_LOCALS triggers a very unpredictable crash in the shader compiler on Qualcomm Adreno (at least 4xx) on Marshmallow. Bug: angleproject:2046 Change-Id: I9a109f7ff442b4e9d3880d137f1a55a19105bcef Reviewed-on: https://chromium-review.googlesource.com/705930 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

dontInitializeUninitializedLocals on Qualcomm only
d63d0007 · Kai Ninomiya · Commit Bot · 359487c8 · d63d0007 · d63d0007
Commit d63d0007 authored Oct 06, 2017 by Kai Ninomiya Committed by Commit Bot Oct 09, 2017
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

CONTRIBUTORS CONTRIBUTORS +1 -0

renderergl_utils.cpp src/libANGLE/renderer/gl/renderergl_utils.cpp +3 -1

No files found.
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -41,6 +41,7 @@ Google Inc.
 Justin Schuh
 Scott Graham
 Corentin Wallez
+ Kai Ninomiya

 Adobe Systems Inc.
 Alexandru Chiculita

--- a/src/libANGLE/renderer/gl/renderergl_utils.cpp
+++ b/src/libANGLE/renderer/gl/renderergl_utils.cpp
@@ -1067,7 +1067,9 @@ void GenerateWorkarounds(const FunctionsGL *functions, WorkaroundsGL *workaround
 #endif

 #if defined(ANGLE_PLATFORM_ANDROID)
-    workarounds->dontInitializeUninitializedLocals = true;
+    // Triggers a bug on Marshmallow Adreno (4xx?) driver.
+    // http://anglebug.com/2046
+    workarounds->dontInitializeUninitializedLocals = IsQualcomm(vendor);
 #endif

    workarounds->finishDoesNotCauseQueriesToBeAvailable =