Commit dc334829 by Geoff Lang Committed by Angle LUCI CQ

Disable ANGLE's VK backend on official Chrome Android builds.

ANGLE's VK backend induces a memory and binary size regression due to global initializers in glslang/spirvtools. Disable it on Android Chrome official builds. Bug: chromium:1172451 Change-Id: I08d77cf11e20b393c0faf7c85d08c92061e5a09b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2969385Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
parent 97fca0c6
...@@ -195,10 +195,11 @@ gn args --list <dir> ...@@ -195,10 +195,11 @@ gn args --list <dir>
### Performance config ### Performance config
This config is designed to get maximum performance by disabling debug configs and validation layers. This config is designed to get maximum performance by disabling debug configs and validation layers.
Note: The oddly named `is_official_build` is a more aggressive optimization level than `Release`. Its names is historical. Note: The oddly named `is_official_build` is a more aggressive optimization level than `Release`. Its name is historical.
``` ```
target_os = "android" target_os = "android"
target_cpu = "arm64" target_cpu = "arm64"
angle_enable_vulkan = true
is_component_build = false is_component_build = false
is_official_build = true is_official_build = true
is_debug = false is_debug = false
......
...@@ -125,6 +125,7 @@ declare_args() { ...@@ -125,6 +125,7 @@ declare_args() {
angle_enable_vulkan = angle_enable_vulkan =
angle_has_build && angle_has_build &&
!(is_android && build_with_chromium && is_official_build) &&
((is_win && !angle_is_winuwp) || ((is_win && !angle_is_winuwp) ||
(is_linux && (angle_use_x11 || angle_use_vulkan_display) && (is_linux && (angle_use_x11 || angle_use_vulkan_display) &&
!is_chromeos) || is_android || is_fuchsia || is_ggp || is_mac) !is_chromeos) || is_android || is_fuchsia || is_ggp || is_mac)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment