Skip to content

A
angle
Commit de3753d4 by Andrii Shyshkalov Committed by Commit Bot
Options

infra: validate configs using lucicfg tool in PRESUBMIT.py

This validates that: a) checked in generated files correspond to what lucicfg actually generates; b) lucicfg is formatted c) (same as before) configs are validated against respective LUCI services. Change-Id: I727723beb4172c3dd265c4a4edbc2ecbfb479eb9 Bug: chromium:1204972 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867081 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 471e62c8
Showing with 12 additions and 4 deletions
infra/config/PRESUBMIT.py
...@@ -4,8 +4,9 @@ ...@@ -4,8 +4,9 @@
def CheckChangeOnUpload(input_api, output_api): def CheckChangeOnUpload(input_api, output_api):
return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api) return input_api.RunTests(
input_api.canned_checks.CheckLucicfgGenOutput(input_api, output_api, 'main.star'))
def CheckChangeOnCommit(input_api, output_api): def CheckChangeOnCommit(input_api, output_api):
return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api) return CheckChangeOnUpload(input_api, output_api)
infra/config/main.star
...@@ -6,7 +6,14 @@ ...@@ -6,7 +6,14 @@
# #
# main.star: lucicfg configuration for ANGLE's standalone builers. # main.star: lucicfg configuration for ANGLE's standalone builers.
lucicfg.config(fail_on_warnings = True) lucicfg.config(
fail_on_warnings = True,
lint_checks = [
"default",
"-module-docstring",
"-function-docstring",
],
)
luci.project( luci.project(
name = "angle", name = "angle",
...@@ -148,7 +155,7 @@ def angle_standalone_builder(name, debug, cpu, toolchain = "clang", uwp = False, ...@@ -148,7 +155,7 @@ def angle_standalone_builder(name, debug, cpu, toolchain = "clang", uwp = False,
dimensions["builderless"] = "1" dimensions["builderless"] = "1"
goma_props["enable_ats"] = True goma_props["enable_ats"] = True
isolated_props = { "server": "https://isolateserver.appspot.com" } isolated_props = {"server": "https://isolateserver.appspot.com"}
properties["$build/goma"] = goma_props properties["$build/goma"] = goma_props
properties["$recipe_engine/isolated"] = isolated_props properties["$recipe_engine/isolated"] = isolated_props
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment