Commit df7d13eb by Olli Etuaho Committed by Commit Bot

Lift outdated NVIDIA test suppressions

Lift some test suppressions for bugs that have been fixed in the NVIDIA driver a good while ago. Also improve code style in some suppressions - prefer IsOSX() and IsLinux() to using ifdefs. BUG=angleproject:1305 TEST=angle_end2end_tests Change-Id: Ia069f5b9696000c901956d2952801d5f5c339a11 Reviewed-on: https://chromium-review.googlesource.com/518168Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
parent 63d8c266
...@@ -355,9 +355,11 @@ TEST_P(ClearTestES3, MixedSRGBClear) ...@@ -355,9 +355,11 @@ TEST_P(ClearTestES3, MixedSRGBClear)
// flush or finish after ClearBufferfv or each draw. // flush or finish after ClearBufferfv or each draw.
TEST_P(ClearTestES3, RepeatedClear) TEST_P(ClearTestES3, RepeatedClear)
{ {
if (IsD3D11() && (IsNVIDIA() || IsIntel())) if (IsD3D11() && IsIntel())
{ {
std::cout << "Test skipped on Nvidia and Intel D3D11." << std::endl; // Note that there's been a bug affecting this test on NVIDIA drivers as well, until fall
// 2016 driver releases.
std::cout << "Test skipped on Intel D3D11." << std::endl;
return; return;
} }
......
...@@ -1086,8 +1086,9 @@ TEST_P(GLSLTest_ES3, MissingReturnArrayOfStructs) ...@@ -1086,8 +1086,9 @@ TEST_P(GLSLTest_ES3, MissingReturnArrayOfStructs)
// Verify that functions without return statements still compile // Verify that functions without return statements still compile
TEST_P(GLSLTest_ES3, MissingReturnStructOfArrays) TEST_P(GLSLTest_ES3, MissingReturnStructOfArrays)
{ {
// TODO(cwallez) remove the suppression once NVIDIA removes the restriction for // TODO(cwallez) remove the suppression once NVIDIA drivers are updated across trybots, drivers
// GLSL >= 300. It was defined only in GLSL 2.0, section 6.1. // since late 2016 should have the fix. Last check on 2017-05-30 revealed that the Windows
// Server 2008 bots still had the old, failing drivers.
if (IsNVIDIA() && IsOpenGLES()) if (IsNVIDIA() && IsOpenGLES())
{ {
std::cout << "Test skipped on NVIDIA OpenGL ES because it disallows returning " std::cout << "Test skipped on NVIDIA OpenGL ES because it disallows returning "
......
...@@ -501,21 +501,17 @@ TEST_P(TransformFeedbackTest, MultiplePaused) ...@@ -501,21 +501,17 @@ TEST_P(TransformFeedbackTest, MultiplePaused)
// contexts returns the correct results. Helps expose bugs in ANGLE's virtual contexts. // contexts returns the correct results. Helps expose bugs in ANGLE's virtual contexts.
TEST_P(TransformFeedbackTest, MultiContext) TEST_P(TransformFeedbackTest, MultiContext)
{ {
#if defined(ANGLE_PLATFORM_APPLE) if (IsOSX() && (IsNVIDIA() || IsAMD() || IsIntel()) && IsOpenGL())
if ((IsNVIDIA() || IsAMD() || IsIntel()) && GetParam() == ES3_OPENGL())
{ {
std::cout << "Test skipped on NVidia, AMD and Intel OpenGL on OSX." << std::endl; std::cout << "Test skipped on NVIDIA, AMD and Intel OpenGL on OSX." << std::endl;
return; return;
} }
#endif
#if defined(ANGLE_PLATFORM_LINUX) if (IsLinux() && IsAMD() && IsOpenGL())
if (IsAMD() && GetParam() == ES3_OPENGL())
{ {
std::cout << "Test skipped on AMD OpenGL on Linux." << std::endl; std::cout << "Test skipped on AMD OpenGL on Linux." << std::endl;
return; return;
} }
#endif
EGLint contextAttributes[] = { EGLint contextAttributes[] = {
EGL_CONTEXT_MAJOR_VERSION_KHR, EGL_CONTEXT_MAJOR_VERSION_KHR,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment