Commit f0eb5bbb by Olli Etuaho

Revert "Display[GLX|CGL]: correctly set the config conformant bits"

Fixes build on Linux. This reverts commit 46439bae. Change-Id: Ie6da92e3ee6cc535f2c153a12af0aa63f6bea665 Reviewed-on: https://chromium-review.googlesource.com/312442Reviewed-by: 's avatarOlli Etuaho <oetuaho@nvidia.com> Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
parent 1d122789
...@@ -151,10 +151,6 @@ egl::ConfigSet DisplayCGL::generateConfigs() const ...@@ -151,10 +151,6 @@ egl::ConfigSet DisplayCGL::generateConfigs() const
// TODO(cwallez): generate more config permutations // TODO(cwallez): generate more config permutations
egl::ConfigSet configs; egl::ConfigSet configs;
const gl::Version &maxVersion = getMaxSupportedESVersion();
ASSERT(maxVersion >= gl::Version(2, 0));
bool supportsES3 = maxVersion >= gl::Version(3, 0);
egl::Config config; egl::Config config;
// Native stuff // Native stuff
...@@ -201,8 +197,8 @@ egl::ConfigSet DisplayCGL::generateConfigs() const ...@@ -201,8 +197,8 @@ egl::ConfigSet DisplayCGL::generateConfigs() const
config.renderTargetFormat = GL_RGBA8; config.renderTargetFormat = GL_RGBA8;
config.depthStencilFormat = GL_DEPTH24_STENCIL8; config.depthStencilFormat = GL_DEPTH24_STENCIL8;
config.conformant = EGL_OPENGL_ES2_BIT | (supportsES3 ? EGL_OPENGL_ES3_BIT_KHR : 0); config.conformant = EGL_OPENGL_ES2_BIT | EGL_OPENGL_ES3_BIT_KHR;
config.renderableType = config.conformant; config.renderableType = EGL_OPENGL_ES2_BIT | EGL_OPENGL_ES3_BIT_KHR;
config.matchNativePixmap = EGL_NONE; config.matchNativePixmap = EGL_NONE;
......
...@@ -338,9 +338,7 @@ egl::ConfigSet DisplayGLX::generateConfigs() const ...@@ -338,9 +338,7 @@ egl::ConfigSet DisplayGLX::generateConfigs() const
egl::ConfigSet configs; egl::ConfigSet configs;
configIdToGLXConfig.clear(); configIdToGLXConfig.clear();
const gl::Version &maxVersion = getMaxSupportedESVersion(); bool hasSwapControl = mGLX.hasExtension("GLX_EXT_swap_control");
ASSERT(maxVersion >= gl::Version(2, 0));
bool supportsES3 = maxVersion >= gl::Version(3, 0);
int contextRedSize = getGLXFBConfigAttrib(mContextConfig, GLX_RED_SIZE); int contextRedSize = getGLXFBConfigAttrib(mContextConfig, GLX_RED_SIZE);
int contextGreenSize = getGLXFBConfigAttrib(mContextConfig, GLX_GREEN_SIZE); int contextGreenSize = getGLXFBConfigAttrib(mContextConfig, GLX_GREEN_SIZE);
...@@ -490,10 +488,9 @@ egl::ConfigSet DisplayGLX::generateConfigs() const ...@@ -490,10 +488,9 @@ egl::ConfigSet DisplayGLX::generateConfigs() const
// TODO(cwallez) wildly guessing these formats, another TODO says they should be removed anyway // TODO(cwallez) wildly guessing these formats, another TODO says they should be removed anyway
config.renderTargetFormat = GL_RGBA8; config.renderTargetFormat = GL_RGBA8;
config.depthStencilFormat = GL_DEPTH24_STENCIL8; config.depthStencilFormat = GL_DEPTH24_STENCIL8;
// TODO(cwallez) Fill after determining the GL version we are using and what ES version it supports
config.conformant = EGL_OPENGL_ES2_BIT | (supportsES3 ? EGL_OPENGL_ES3_BIT_KHR : 0); config.conformant = EGL_OPENGL_ES2_BIT | EGL_OPENGL_ES3_BIT_KHR;
config.renderableType = config.conformant; config.renderableType = EGL_OPENGL_ES2_BIT | EGL_OPENGL_ES3_BIT_KHR;
// TODO(cwallez) I have no idea what this is // TODO(cwallez) I have no idea what this is
config.matchNativePixmap = EGL_NONE; config.matchNativePixmap = EGL_NONE;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment