Build fix: not all types support precisions.

Currently Angle translator made the wrong assumption that all variables have a precision, and ASSERT that. BUG=276031 TBR=alokp@chromium.org Review URL: https://codereview.appspot.com/13113044

Build fix: not all types support precisions.
fa3c346f · Zhenyao Mo · Jamie Madill · a5a1dfc6 · fa3c346f · fa3c346f
Commit fa3c346f authored Sep 23, 2013 by Zhenyao Mo Committed by Jamie Madill Sep 24, 2013
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

ShaderLang.h include/GLSLANG/ShaderLang.h +2 -1

version.h src/common/version.h +1 -1

ShaderLang.cpp src/compiler/ShaderLang.cpp +3 -1

No files found.
--- a/include/GLSLANG/ShaderLang.h
+++ b/include/GLSLANG/ShaderLang.h
@@ -134,7 +134,8 @@ typedef enum {
 typedef enum {
  SH_PRECISION_HIGHP     = 0x5001,
  SH_PRECISION_MEDIUMP   = 0x5002,
-  SH_PRECISION_LOWP     = 0x5003
+  SH_PRECISION_LOWP      = 0x5003,
+  SH_PRECISION_UNDEFINED = 0
 } ShPrecisionType;
 typedef enum {

--- a/src/common/version.h
+++ b/src/common/version.h
 #define MAJOR_VERSION 2
 #define MINOR_VERSION 0
 #define BUILD_VERSION 0
-#define BUILD_REVISION 2009
+#define BUILD_REVISION 2010
 #define STRINGIFY(x) #x
 #define MACRO_STRINGIFY(x) STRINGIFY(x)

--- a/src/compiler/ShaderLang.cpp
+++ b/src/compiler/ShaderLang.cpp
@@ -293,7 +293,9 @@ void ShGetVariableInfo(const ShHandle handle,
        *precision = SH_PRECISION_HIGHP;
        break;
    default:
-        ASSERT(false);
+        // Some types does not support precision, for example, boolean.
+        *precision = SH_PRECISION_UNDEFINED;
+        break;
    }
    // This size must match that queried by