Vulkan: Allow commands to completely fill allocation

If the remaining allocation size for commands in the SecondaryCommandBuffer class is equal to the command allocation size and the follow-on header, then we can fill the allocation. Previously we were conservative and if the size needed exactly equals the size remaining, we would allocate a new block. Bug: b/154030403 Change-Id: Ie31f0f5d33782d12adbaea9e3b02598a004d7643 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158817Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>

Vulkan: Allow commands to completely fill allocation
fe60973b · Tobin Ehlis · Commit Bot · 9dc322d7 · fe60973b
Commit fe60973b authored Apr 21, 2020 by Tobin Ehlis Committed by Commit Bot Apr 21, 2020
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

SecondaryCommandBuffer.h src/libANGLE/renderer/vulkan/SecondaryCommandBuffer.h +2 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/SecondaryCommandBuffer.h
+++ b/src/libANGLE/renderer/vulkan/SecondaryCommandBuffer.h
@@ -699,7 +699,7 @@ class SecondaryCommandBuffer final : angle::NonCopyable
        constexpr size_t fixedAllocationSize = sizeof(StructType) + sizeof(CommandHeader);
        const size_t allocationSize          = fixedAllocationSize + variableSize;
        // Make sure we have enough room to mark follow-on header "Invalid"
-        if (mCurrentBytesRemaining <= (allocationSize + sizeof(CommandHeader)))
+        if (mCurrentBytesRemaining < (allocationSize + sizeof(CommandHeader)))
        {
            allocateNewBlock();
        }
@@ -713,7 +713,7 @@ class SecondaryCommandBuffer final : angle::NonCopyable
    {
        constexpr size_t allocationSize = sizeof(StructType) + sizeof(CommandHeader);
        // Make sure we have enough room to mark follow-on header "Invalid"
-        if (mCurrentBytesRemaining <= (allocationSize + sizeof(CommandHeader)))
+        if (mCurrentBytesRemaining < (allocationSize + sizeof(CommandHeader)))
        {
            allocateNewBlock();
        }