Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
googletest
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
googletest
Commits
a91e4e73
Commit
a91e4e73
authored
Nov 22, 2019
by
Krystian Kuzniarek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
remove stale comments about older GCC versions
parent
f9665846
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
12 deletions
+0
-12
gtest_unittest.cc
googletest/test/gtest_unittest.cc
+0
-12
No files found.
googletest/test/gtest_unittest.cc
View file @
a91e4e73
...
@@ -3080,8 +3080,6 @@ TEST_F(DoubleTest, EXPECT_NEAR) {
...
@@ -3080,8 +3080,6 @@ TEST_F(DoubleTest, EXPECT_NEAR) {
EXPECT_NONFATAL_FAILURE
(
EXPECT_NEAR
(
1.0
,
1.5
,
0.25
),
// NOLINT
EXPECT_NONFATAL_FAILURE
(
EXPECT_NEAR
(
1.0
,
1.5
,
0.25
),
// NOLINT
"The difference between 1.0 and 1.5 is 0.5, "
"The difference between 1.0 and 1.5 is 0.5, "
"which exceeds 0.25"
);
"which exceeds 0.25"
);
// To work around a bug in gcc 2.95.0, there is intentionally no
// space after the first comma in the previous statement.
}
}
// Tests ASSERT_NEAR.
// Tests ASSERT_NEAR.
...
@@ -3091,8 +3089,6 @@ TEST_F(DoubleTest, ASSERT_NEAR) {
...
@@ -3091,8 +3089,6 @@ TEST_F(DoubleTest, ASSERT_NEAR) {
EXPECT_FATAL_FAILURE
(
ASSERT_NEAR
(
1.0
,
1.5
,
0.25
),
// NOLINT
EXPECT_FATAL_FAILURE
(
ASSERT_NEAR
(
1.0
,
1.5
,
0.25
),
// NOLINT
"The difference between 1.0 and 1.5 is 0.5, "
"The difference between 1.0 and 1.5 is 0.5, "
"which exceeds 0.25"
);
"which exceeds 0.25"
);
// To work around a bug in gcc 2.95.0, there is intentionally no
// space after the first comma in the previous statement.
}
}
// Tests the cases where DoubleLE() should succeed.
// Tests the cases where DoubleLE() should succeed.
...
@@ -3734,10 +3730,6 @@ TEST(AssertionTest, ASSERT_EQ) {
...
@@ -3734,10 +3730,6 @@ TEST(AssertionTest, ASSERT_EQ) {
TEST
(
AssertionTest
,
ASSERT_EQ_NULL
)
{
TEST
(
AssertionTest
,
ASSERT_EQ_NULL
)
{
// A success.
// A success.
const
char
*
p
=
nullptr
;
const
char
*
p
=
nullptr
;
// Some older GCC versions may issue a spurious warning in this or the next
// assertion statement. This warning should not be suppressed with
// static_cast since the test verifies the ability to use bare NULL as the
// expected parameter to the macro.
ASSERT_EQ
(
nullptr
,
p
);
ASSERT_EQ
(
nullptr
,
p
);
// A failure.
// A failure.
...
@@ -4458,10 +4450,6 @@ TEST(ExpectTest, EXPECT_EQ_Double) {
...
@@ -4458,10 +4450,6 @@ TEST(ExpectTest, EXPECT_EQ_Double) {
TEST
(
ExpectTest
,
EXPECT_EQ_NULL
)
{
TEST
(
ExpectTest
,
EXPECT_EQ_NULL
)
{
// A success.
// A success.
const
char
*
p
=
nullptr
;
const
char
*
p
=
nullptr
;
// Some older GCC versions may issue a spurious warning in this or the next
// assertion statement. This warning should not be suppressed with
// static_cast since the test verifies the ability to use bare NULL as the
// expected parameter to the macro.
EXPECT_EQ
(
nullptr
,
p
);
EXPECT_EQ
(
nullptr
,
p
);
// A failure.
// A failure.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment