Commit 08be058f by Christian Brauner Committed by Stéphane Graber

fix lxc_console_cb_tty_*()

Clean exit when read() == -1 && errno != EINTR or read() == 0. Signed-off-by: 's avatarChristian Brauner <christian.brauner@mailbox.org>
parent 32bf1787
...@@ -571,14 +571,9 @@ int lxc_console_cb_tty_stdin(int fd, uint32_t events, void *cbdata, ...@@ -571,14 +571,9 @@ int lxc_console_cb_tty_stdin(int fd, uint32_t events, void *cbdata,
struct lxc_tty_state *ts = cbdata; struct lxc_tty_state *ts = cbdata;
char c; char c;
if (events & EPOLLHUP)
return 1;
assert(fd == ts->stdinfd); assert(fd == ts->stdinfd);
if (read(ts->stdinfd, &c, 1) < 0) { if (lxc_read_nointr(ts->stdinfd, &c, 1) <= 0)
SYSERROR("failed to read");
return 1; return 1;
}
if (ts->escape != -1) { if (ts->escape != -1) {
/* we want to exit the console with Ctrl+a q */ /* we want to exit the console with Ctrl+a q */
...@@ -593,10 +588,8 @@ int lxc_console_cb_tty_stdin(int fd, uint32_t events, void *cbdata, ...@@ -593,10 +588,8 @@ int lxc_console_cb_tty_stdin(int fd, uint32_t events, void *cbdata,
ts->saw_escape = 0; ts->saw_escape = 0;
} }
if (write(ts->masterfd, &c, 1) < 0) { if (lxc_write_nointr(ts->masterfd, &c, 1) <= 0)
SYSERROR("failed to write");
return 1; return 1;
}
return 0; return 0;
} }
...@@ -608,18 +601,15 @@ int lxc_console_cb_tty_master(int fd, uint32_t events, void *cbdata, ...@@ -608,18 +601,15 @@ int lxc_console_cb_tty_master(int fd, uint32_t events, void *cbdata,
char buf[1024]; char buf[1024];
int r, w; int r, w;
if (events & EPOLLHUP)
return 1;
assert(fd == ts->masterfd); assert(fd == ts->masterfd);
r = read(fd, buf, sizeof(buf)); r = lxc_read_nointr(fd, buf, sizeof(buf));
if (r < 0) { if (r <= 0)
SYSERROR("failed to read");
return 1; return 1;
}
w = write(ts->stdoutfd, buf, r); w = lxc_write_nointr(ts->stdoutfd, buf, r);
if (w < 0 || w != r) { if (w <= 0) {
return 1;
} else if (w != r) {
SYSERROR("failed to write"); SYSERROR("failed to write");
return 1; return 1;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment