Commit 1787abca by Jean-Tiare LE BIGOT

Report container exit status to monitord

When managing containers, I need to take action based on container exit status. For instance, if it exited abnormally (status!=0), I sometime want to respawn it automatically. Or, when invoking `lxc-stop` I want to know if it terminated gracefully (ie on `SIGTERM`) or on `SIGKILL` after a timeout. This patch adds a new message type `lxc_msg_exit_code,` to preserve ABI. It sends the raw status code as returned by `waitpid` so that listening application may want to apply `WEXITSTATUS` before. This is what `lxc-monitor` does. Signed-off-by: 's avatarJean-Tiare LE BIGOT <jean-tiare.le-bigot@ovh.net>
parent d6559c5d
...@@ -27,6 +27,7 @@ ...@@ -27,6 +27,7 @@
#include <unistd.h> #include <unistd.h>
#include <regex.h> #include <regex.h>
#include <sys/types.h> #include <sys/types.h>
#include <sys/wait.h>
#include <errno.h> #include <errno.h>
#include "lxc.h" #include "lxc.h"
...@@ -172,6 +173,10 @@ int main(int argc, char *argv[]) ...@@ -172,6 +173,10 @@ int main(int argc, char *argv[])
printf("'%s' changed state to [%s]\n", printf("'%s' changed state to [%s]\n",
msg.name, lxc_state2str(msg.value)); msg.name, lxc_state2str(msg.value));
break; break;
case lxc_msg_exit_code:
printf("'%s' exited with status [%d]\n",
msg.name, WEXITSTATUS(msg.value));
break;
default: default:
/* ignore garbage */ /* ignore garbage */
break; break;
......
...@@ -131,6 +131,16 @@ void lxc_monitor_send_state(const char *name, lxc_state_t state, const char *lxc ...@@ -131,6 +131,16 @@ void lxc_monitor_send_state(const char *name, lxc_state_t state, const char *lxc
lxc_monitor_fifo_send(&msg, lxcpath); lxc_monitor_fifo_send(&msg, lxcpath);
} }
void lxc_monitor_send_exit_code(const char *name, int exit_code, const char *lxcpath)
{
struct lxc_msg msg = { .type = lxc_msg_exit_code,
.value = exit_code };
strncpy(msg.name, name, sizeof(msg.name));
msg.name[sizeof(msg.name) - 1] = 0;
lxc_monitor_fifo_send(&msg, lxcpath);
}
/* routines used by monitor subscribers (lxc-monitor) */ /* routines used by monitor subscribers (lxc-monitor) */
int lxc_monitor_close(int fd) int lxc_monitor_close(int fd)
......
...@@ -32,6 +32,7 @@ ...@@ -32,6 +32,7 @@
typedef enum { typedef enum {
lxc_msg_state, lxc_msg_state,
lxc_msg_priority, lxc_msg_priority,
lxc_msg_exit_code,
} lxc_msg_type_t; } lxc_msg_type_t;
struct lxc_msg { struct lxc_msg {
...@@ -46,6 +47,8 @@ extern int lxc_monitor_fifo_name(const char *lxcpath, char *fifo_path, ...@@ -46,6 +47,8 @@ extern int lxc_monitor_fifo_name(const char *lxcpath, char *fifo_path,
size_t fifo_path_sz, int do_mkdirp); size_t fifo_path_sz, int do_mkdirp);
extern void lxc_monitor_send_state(const char *name, lxc_state_t state, extern void lxc_monitor_send_state(const char *name, lxc_state_t state,
const char *lxcpath); const char *lxcpath);
extern void lxc_monitor_send_exit_code(const char *name, int exit_code,
const char *lxcpath);
extern int lxc_monitord_spawn(const char *lxcpath); extern int lxc_monitord_spawn(const char *lxcpath);
#endif #endif
...@@ -1139,6 +1139,7 @@ int __lxc_start(const char *name, struct lxc_conf *conf, ...@@ -1139,6 +1139,7 @@ int __lxc_start(const char *name, struct lxc_conf *conf,
handler->pinfd = -1; handler->pinfd = -1;
} }
lxc_monitor_send_exit_code(name, status, handler->lxcpath);
err = lxc_error_set_and_log(handler->pid, status); err = lxc_error_set_and_log(handler->pid, status);
out_fini: out_fini:
lxc_delete_network(handler); lxc_delete_network(handler);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment