network: do not log false friends

The netlink functions just return -1 and not specific negative errno values so logging them doesn't make any sense. Fixes: https://discuss.linuxcontainers.org/t/warning-in-the-container-log/4072/2Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: do not log false friends
24548539 · Christian Brauner · 29a7b484 · 24548539
Unverified Commit 24548539 authored Feb 15, 2019 by Christian Brauner
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

network.c src/lxc/network.c +2 -4

No files found.
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -2581,8 +2581,7 @@ bool lxc_delete_network_priv(struct lxc_handler *handler)
 			     netdev->name[0] != '\0' ? netdev->name : "(null)",
 			     netdev->ifindex);
 		} else if (ret < 0) {
-			errno = -ret;
+			WARN("Failed to remove interface \"%s\" with index %d",
-			SYSWARN("Failed to remove interface \"%s\" with index %d",
 			     netdev->name[0] != '\0' ? netdev->name : "(null)",
 			     netdev->ifindex);
 			goto clear_ifindices;
@@ -2606,8 +2605,7 @@ bool lxc_delete_network_priv(struct lxc_handler *handler)
 		ret = lxc_netdev_delete_by_name(hostveth);
 		if (ret < 0) {
-			errno = -ret;
+			WARN("Failed to remove interface \"%s\" from \"%s\"",
-			SYSWARN("Failed to remove interface \"%s\" from \"%s\"",
 			     hostveth, netdev->link);
 			goto clear_ifindices;
 		}