criu: DECLARE_ARG should check for null arguments

This is in preparation for the cgroups creation work, but also probably just a good idea in general. The ERROR message is handy since we print line nos. it will to give people an indication of what arg was null. Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

criu: DECLARE_ARG should check for null arguments
2566a145 · Tycho Andersen · Serge Hallyn · 9a64d3cf · 2566a145
Commit 2566a145 authored Oct 08, 2014 by Tycho Andersen Committed by Serge Hallyn Oct 08, 2014
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

lxccontainer.c src/lxc/lxccontainer.c +4 -0

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -3556,6 +3556,10 @@ static void exec_criu(struct criu_opts *opts)
 #define DECLARE_ARG(arg) 					\
 	do {							\
+		if (arg == NULL) {				\
+			ERROR("Got NULL argument for criu");	\
+			goto err;				\
+		}						\
 		argv[argc++] = strdup(arg);			\
 		if (!argv[argc-1])				\
 			goto err;				\