the lxc_unlink_nsgroup may fail on ppc. V2

the lxc_unlink_nsgroup may fail on ppc where the stack is not zeroed by default and because the readlink function do not add trailing null character. Signed-off-by: Michel Normand <normand@fr.ibm.com> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>

the lxc_unlink_nsgroup may fail on ppc. V2
2b4e286d · Michel Normand · Daniel Lezcano · 47ad75f8 · 2b4e286d
Commit 2b4e286d authored Jun 25, 2009 by Michel Normand Committed by Daniel Lezcano Jun 25, 2009
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

cgroup.c src/lxc/cgroup.c +5 -1

No files found.
--- a/src/lxc/cgroup.c
+++ b/src/lxc/cgroup.c
@@ -114,11 +114,15 @@ int lxc_unlink_nsgroup(const char *name)
 {
 	char nsgroup[MAXPATHLEN];
 	char path[MAXPATHLEN];
+	ssize_t len;

 	snprintf(nsgroup, MAXPATHLEN, LXCPATH "/%s/nsgroup", name);
 	
-	if (readlink(nsgroup, path, MAXPATHLEN) >  0)
+	len = readlink(nsgroup, path, MAXPATHLEN-1);
+	if (len >  0) {
+		path[len] = '\0';
 		rmdir(path);
+	}

 	return unlink(nsgroup);
 }