pass on reboot flag and delete old veth on reboot

When setting lxc.network.veth.pair to get a fixed interface name the recreation of it after a reboot caused an EEXIST. -) The reboot flag is now a three-state value. It's set to 1 to request a reboot, and 2 during a reboot until after lxc_spawn where it is reset to 0. -) If the reboot is set (!= 0) within instantiate_veth and a fixed name is used, the interface is now deleted before being recreated. Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

pass on reboot flag and delete old veth on reboot
2b72f41e · Wolfgang Bumiller · Stéphane Graber · ed338df9 · 2b72f41e · 2b72f41e
Commit 2b72f41e authored Jul 27, 2015 by Wolfgang Bumiller Committed by Stéphane Graber Aug 28, 2015
Show whitespace changes
Inline Side-by-side

Showing with 10 additions and 5 deletions

conf.c src/lxc/conf.c +4 -2

lxccontainer.c src/lxc/lxccontainer.c +4 -3

start.c src/lxc/start.c +2 -0

No files found.
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -2921,9 +2921,11 @@ static int instantiate_veth(struct lxc_handler *handler, struct lxc_netdev *netd
 	char veth2buf[IFNAMSIZ], *veth2;
 	int err;

-	if (netdev->priv.veth_attr.pair)
+	if (netdev->priv.veth_attr.pair) {
 		veth1 = netdev->priv.veth_attr.pair;
-	else {
+		if (handler->conf->reboot)
+			lxc_netdev_delete_by_name(veth1);
+	} else {
 		err = snprintf(veth1buf, sizeof(veth1buf), "vethXXXXXX");
 		if (err >= sizeof(veth1buf)) { /* can't *really* happen, but... */
 			ERROR("veth1 name too long");

--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -661,14 +661,15 @@ static bool lxcapi_start(struct lxc_container *c, int useinit, char * const argv
 		pid_fp = NULL;
 	}

-reboot:
 	conf->reboot = 0;
+
+reboot:
 	ret = lxc_start(c->name, argv, conf, c->config_path);
 	c->error_num = ret;

-	if (conf->reboot) {
+	if (conf->reboot == 1) {
 		INFO("container requested reboot");
-		conf->reboot = 0;
+		conf->reboot = 2;
 		goto reboot;
 	}


--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -1081,6 +1081,8 @@ int __lxc_start(const char *name, struct lxc_conf *conf,
 		goto out_fini_nonet;
 	}

+	handler->conf->reboot = 0;
+
 	netnsfd = get_netns_fd(handler->pid);

 	err = lxc_poll(name, handler);