Unverified Commit 4d3d037a by Stéphane Graber Committed by GitHub

Merge pull request #2857 from brauner/2019-02-15/tweak_log

log: fixes
parents 2cd64122 24548539
...@@ -1639,11 +1639,7 @@ static int lxc_setup_devpts(struct lxc_conf *conf) ...@@ -1639,11 +1639,7 @@ static int lxc_setup_devpts(struct lxc_conf *conf)
if (ret < 0 || (size_t)ret >= sizeof(devpts_mntopts)) if (ret < 0 || (size_t)ret >= sizeof(devpts_mntopts))
return -1; return -1;
ret = umount2("/dev/pts", MNT_DETACH); (void)umount2("/dev/pts", MNT_DETACH);
if (ret < 0)
SYSWARN("Failed to unmount old devpts instance");
else
DEBUG("Unmounted old devpts instance");
/* Create mountpoint for devpts instance. */ /* Create mountpoint for devpts instance. */
ret = mkdir("/dev/pts", 0755); ret = mkdir("/dev/pts", 0755);
......
...@@ -2581,8 +2581,7 @@ bool lxc_delete_network_priv(struct lxc_handler *handler) ...@@ -2581,8 +2581,7 @@ bool lxc_delete_network_priv(struct lxc_handler *handler)
netdev->name[0] != '\0' ? netdev->name : "(null)", netdev->name[0] != '\0' ? netdev->name : "(null)",
netdev->ifindex); netdev->ifindex);
} else if (ret < 0) { } else if (ret < 0) {
errno = -ret; WARN("Failed to remove interface \"%s\" with index %d",
SYSWARN("Failed to remove interface \"%s\" with index %d",
netdev->name[0] != '\0' ? netdev->name : "(null)", netdev->name[0] != '\0' ? netdev->name : "(null)",
netdev->ifindex); netdev->ifindex);
goto clear_ifindices; goto clear_ifindices;
...@@ -2606,8 +2605,7 @@ bool lxc_delete_network_priv(struct lxc_handler *handler) ...@@ -2606,8 +2605,7 @@ bool lxc_delete_network_priv(struct lxc_handler *handler)
ret = lxc_netdev_delete_by_name(hostveth); ret = lxc_netdev_delete_by_name(hostveth);
if (ret < 0) { if (ret < 0) {
errno = -ret; WARN("Failed to remove interface \"%s\" from \"%s\"",
SYSWARN("Failed to remove interface \"%s\" from \"%s\"",
hostveth, netdev->link); hostveth, netdev->link);
goto clear_ifindices; goto clear_ifindices;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment