fix free() of args to startl

Coverity 1076328 marked this as "Use after free", which it isn't really, its actually just free()ing the wrong 2nd, 3rd, etc... pointers. Test by passing two or more args to startl, without this change you get segfault when free()ing the second pointer/arg. Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Acked-by: Stéphane Graber <stgraber@ubuntu.com>

fix free() of args to startl
4e03ae57 · Dwight Engen · Stéphane Graber · 9588a6ce · 4e03ae57
Commit 4e03ae57 authored Oct 29, 2013 by Dwight Engen Committed by Stéphane Graber Oct 29, 2013
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

lxccontainer.c src/lxc/lxccontainer.c +3 -3

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -641,9 +641,9 @@ static bool lxcapi_startl(struct lxc_container *c, int useinit, ...)

 out:
 	if (inargs) {
-		char *arg;
-		for (arg = *inargs; arg; arg++)
-			free(arg);
+		char **arg;
+		for (arg = inargs; *arg; arg++)
+			free(*arg);
 		free(inargs);
 	}