Commit 75b1e198 by Michel Normand Committed by Daniel Lezcano

lxc-monitor and lxc-wait to return 255 in case of error

to have same exit code for all lxc commands Signed-off-by: 's avatarMichel Normand <normand@fr.ibm.com> Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
parent 272bc5af
...@@ -56,22 +56,21 @@ int main(int argc, char *argv[]) ...@@ -56,22 +56,21 @@ int main(int argc, char *argv[])
char *regexp; char *regexp;
struct lxc_msg msg; struct lxc_msg msg;
regex_t preg; regex_t preg;
int fd, ret; int fd;
ret = lxc_arguments_parse(&my_args, argc, argv); if (lxc_arguments_parse(&my_args, argc, argv))
if (ret) return -1;
return 1;
if (lxc_log_init(my_args.log_file, my_args.log_priority, if (lxc_log_init(my_args.log_file, my_args.log_priority,
my_args.progname, my_args.quiet)) my_args.progname, my_args.quiet))
return 1; return -1;
regexp = malloc(strlen(my_args.name) + 3); regexp = malloc(strlen(my_args.name) + 3);
sprintf(regexp, "^%s$", my_args.name); sprintf(regexp, "^%s$", my_args.name);
if (regcomp(&preg, regexp, REG_NOSUB|REG_EXTENDED)) { if (regcomp(&preg, regexp, REG_NOSUB|REG_EXTENDED)) {
ERROR("failed to compile the regex '%s'", my_args.name); ERROR("failed to compile the regex '%s'", my_args.name);
return 1; return -1;
} }
fd = lxc_monitor_open(); fd = lxc_monitor_open();
......
...@@ -95,19 +95,16 @@ int main(int argc, char *argv[]) ...@@ -95,19 +95,16 @@ int main(int argc, char *argv[])
{ {
struct lxc_msg msg; struct lxc_msg msg;
int s[MAX_STATE] = { }, fd; int s[MAX_STATE] = { }, fd;
int ret;
ret = lxc_arguments_parse(&my_args, argc, argv); if (lxc_arguments_parse(&my_args, argc, argv))
if (ret) return -1;
return 1;
if (lxc_log_init(my_args.log_file, my_args.log_priority, if (lxc_log_init(my_args.log_file, my_args.log_priority,
my_args.progname, my_args.quiet)) my_args.progname, my_args.quiet))
return -1; return -1;
ret = fillwaitedstates(my_args.states, s); if (fillwaitedstates(my_args.states, s))
if (ret) return -1;
return 1;
fd = lxc_monitor_open(); fd = lxc_monitor_open();
if (fd < 0) if (fd < 0)
......
...@@ -163,7 +163,7 @@ int lxc_monitor_read(int fd, struct lxc_msg *msg) ...@@ -163,7 +163,7 @@ int lxc_monitor_read(int fd, struct lxc_msg *msg)
(struct sockaddr *)&from, &len); (struct sockaddr *)&from, &len);
if (ret < 0) { if (ret < 0) {
SYSERROR("failed to receive state"); SYSERROR("failed to receive state");
return -LXC_ERROR_INTERNAL; return -1;
} }
return ret; return ret;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment