terminal: lxc_terminal_set_stdfds()

src/lxc/terminal.c

@@ -931,28 +931,33 @@ err:
 	return -ENODEV;
 }
 
-int lxc_terminal_set_stdfds(int fd)
+static bool __terminal_dup2(int duplicate, int original)
 {
-	if (fd < 0)
-		return 0;
+	int ret;
 
-	if (isatty(STDIN_FILENO))
-		if (dup2(fd, STDIN_FILENO) < 0) {
-			SYSERROR("failed to duplicate stdin.");
-			return -1;
-		}
+	if (!isatty(original))
+		return true;
 
-	if (isatty(STDOUT_FILENO))
-		if (dup2(fd, STDOUT_FILENO) < 0) {
-			SYSERROR("failed to duplicate stdout.");
-			return -1;
+	ret = dup2(duplicate, original);
+	if (ret < 0) {
+		SYSERROR("Failed to dup2(%d, %d)", duplicate, original);
+		return false;
 	}
 
-	if (isatty(STDERR_FILENO))
-		if (dup2(fd, STDERR_FILENO) < 0) {
-			SYSERROR("failed to duplicate stderr.");
+	return true;
+}
+
+int lxc_terminal_set_stdfds(int fd)
+{
+	int i;
+
+	if (fd < 0)
+		return 0;
+
+	for (i = 0; i < 3; i++)
+		if (!__terminal_dup2(fd, (int[]){STDIN_FILENO, STDOUT_FILENO,
+						 STDERR_FILENO}[i]))
 			return -1;
-		}
 
 	return 0;
 }