Commit a27ed52b by Robert Vogelgesang Committed by Stéphane Graber

lxc-monitord.log should not be created with mode 0666

lxc_monitord_spawn() in src/lxc/monitor.c contained "umask(0);", and because of this, lxc-monitord created lxc-monitord.log with mode 0666. World-writeable log files are bad, so remove this umask(0). Signed-off-by: 's avatarRobert Vogelgesang <vogel@users.sourceforge.net> Acked-by: 's avatarDwight Engen <dwight.engen@oracle.com> Acked-by: 's avatarStéphane Graber <stgraber@ubuntu.com>
parent 1bdedfac
...@@ -325,7 +325,6 @@ int lxc_monitord_spawn(const char *lxcpath) ...@@ -325,7 +325,6 @@ int lxc_monitord_spawn(const char *lxcpath)
exit(EXIT_SUCCESS); exit(EXIT_SUCCESS);
} }
umask(0);
if (setsid() < 0) { if (setsid() < 0) {
SYSERROR("failed to setsid"); SYSERROR("failed to setsid");
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment