lxccontainer: use snprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: use snprintf()
b1e22e81 · Christian Brauner · Stéphane Graber · 929d2675 · b1e22e81
Unverified Commit b1e22e81 authored Jul 15, 2017 by Christian Brauner Committed by Stéphane Graber Aug 17, 2017
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

lxccontainer.c src/lxc/lxccontainer.c +5 -1

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -2679,7 +2679,11 @@ static struct lxc_container *lxcapi_clone(struct lxc_container *c, const char *n
 	fclose(fout);
 	c->lxc_conf->rootfs.path = origroot;
-	sprintf(newpath, "%s/%s/rootfs", lxcpath, newname);
+	ret = snprintf(newpath, MAXPATHLEN, "%s/%s/rootfs", lxcpath, newname);
+	if (ret < 0 || ret >= MAXPATHLEN) {
+		SYSERROR("clone: failed making rootfs pathname");
+		goto out;
+	}
 	if (mkdir(newpath, 0755) < 0) {
 		SYSERROR("error creating %s", newpath);
 		goto out;