Skip to content

L
lxc
Unverified Commit bad943c4 by Christian Brauner Committed by GitHub
Options

Merge pull request #2021 from 3XX0/overlay-oob-copy

overlay: fix out-of-bounds copy
parents f449521c fe348547
Showing with 1 addition and 4 deletions
src/lxc/storage/overlay.c
...@@ -410,15 +410,12 @@ int ovl_create(struct lxc_storage *bdev, const char *dest, const char *n, ...@@ -410,15 +410,12 @@ int ovl_create(struct lxc_storage *bdev, const char *dest, const char *n,
return -1; return -1;
} }
delta = malloc(len + 1); delta = strdup(dest);
if (!delta) { if (!delta) {
ERROR("Failed to allocate memory"); ERROR("Failed to allocate memory");
return -1; return -1;
} }
memcpy(delta, dest, len);
memcpy(delta + len - 6, "delta0", sizeof("delta0") - 1); memcpy(delta + len - 6, "delta0", sizeof("delta0") - 1);
delta[len + sizeof("delta0")] = '\0';
ret = mkdir_p(delta, 0755); ret = mkdir_p(delta, 0755);
if (ret < 0) { if (ret < 0) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment