c/r: use sizeof instead of magic numbers

Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com> Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

c/r: use sizeof instead of magic numbers
e311a562 · Tycho Andersen · Serge Hallyn · fed29fad · e311a562
Commit e311a562 authored Oct 16, 2014 by Tycho Andersen Committed by Serge Hallyn Oct 17, 2014
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

lxccontainer.c src/lxc/lxccontainer.c +4 -4

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -3639,16 +3639,16 @@ static void exec_criu(struct criu_opts *opts)
 			struct lxc_netdev *n = it->elem;
 			if (n->name) {
-				if (strlen(n->name) >= 128)
+				if (strlen(n->name) >= sizeof(eth))
 					goto err;
-				strncpy(eth, n->name, 128);
+				strncpy(eth, n->name, sizeof(eth));
 			} else
 				sprintf(eth, "eth%d", netnr);
 			veth = n->priv.veth_attr.pair;
-			ret = snprintf(buf, 257, "%s=%s", eth, veth);
+			ret = snprintf(buf, sizeof(buf), "%s=%s", eth, veth);
-			if (ret < 0 || ret >= 257)
+			if (ret < 0 || ret >= sizeof(buf))
 				goto err;
 			/* final NULL and --veth-pair eth0=vethASDF */