Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
L
lxc
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
lxc
Commits
e66b6c96
Commit
e66b6c96
authored
Apr 08, 2016
by
Christian Brauner
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix lxc_console_cb_tty_*()
Clean exit when read() == -1 && errno != EINTR or read() == 0. Signed-off-by:
Christian Brauner
<
christian.brauner@mailbox.org
>
parent
3e6580ec
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
18 deletions
+8
-18
console.c
src/lxc/console.c
+8
-18
No files found.
src/lxc/console.c
View file @
e66b6c96
...
...
@@ -571,14 +571,9 @@ int lxc_console_cb_tty_stdin(int fd, uint32_t events, void *cbdata,
struct
lxc_tty_state
*
ts
=
cbdata
;
char
c
;
if
(
events
&
EPOLLHUP
)
return
1
;
assert
(
fd
==
ts
->
stdinfd
);
if
(
read
(
ts
->
stdinfd
,
&
c
,
1
)
<
0
)
{
SYSERROR
(
"failed to read"
);
if
(
lxc_read_nointr
(
ts
->
stdinfd
,
&
c
,
1
)
<=
0
)
return
1
;
}
if
(
ts
->
escape
!=
-
1
)
{
/* we want to exit the console with Ctrl+a q */
...
...
@@ -593,10 +588,8 @@ int lxc_console_cb_tty_stdin(int fd, uint32_t events, void *cbdata,
ts
->
saw_escape
=
0
;
}
if
(
write
(
ts
->
masterfd
,
&
c
,
1
)
<
0
)
{
SYSERROR
(
"failed to write"
);
if
(
lxc_write_nointr
(
ts
->
masterfd
,
&
c
,
1
)
<=
0
)
return
1
;
}
return
0
;
}
...
...
@@ -608,18 +601,15 @@ int lxc_console_cb_tty_master(int fd, uint32_t events, void *cbdata,
char
buf
[
1024
];
int
r
,
w
;
if
(
events
&
EPOLLHUP
)
return
1
;
assert
(
fd
==
ts
->
masterfd
);
r
=
read
(
fd
,
buf
,
sizeof
(
buf
));
if
(
r
<
0
)
{
SYSERROR
(
"failed to read"
);
r
=
lxc_read_nointr
(
fd
,
buf
,
sizeof
(
buf
));
if
(
r
<=
0
)
return
1
;
}
w
=
write
(
ts
->
stdoutfd
,
buf
,
r
);
if
(
w
<
0
||
w
!=
r
)
{
w
=
lxc_write_nointr
(
ts
->
stdoutfd
,
buf
,
r
);
if
(
w
<=
0
)
{
return
1
;
}
else
if
(
w
!=
r
)
{
SYSERROR
(
"failed to write"
);
return
1
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment