Fix signed integer overflow.

Signed integer overflow is undefined behavior in C++. Change-Id: I12b7507a9624312a615826fd0a1d9cb30b8f8b58 Reviewed-on: https://swiftshader-review.googlesource.com/c/21768Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com>

Fix signed integer overflow.
17dfe1b6 · Nicolas Capens · Nicolas Capens · d55d9973 · 17dfe1b6 · 17dfe1b6
Commit 17dfe1b6 authored Oct 19, 2018 by Nicolas Capens Committed by Nicolas Capens Oct 19, 2018
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

Math.hpp src/Common/Math.hpp +1 -1

Math.hpp src/System/Math.hpp +1 -1

No files found.
--- a/src/Common/Math.hpp
+++ b/src/Common/Math.hpp
@@ -203,7 +203,7 @@ namespace sw
 		// IEEE-754 floating-point numbers are sorted by magnitude in the same way as integers,
 		// except negative values are like one's complement integers. Convert them to two's complement.
 		int32_t i = bit_cast<int32_t>(f);
-		return (i < 0) ? (0x7FFFFFFF - i) : i;
+		return (i < 0) ? (0x7FFFFFFFu - i) : i;
 	}
 	// 'Safe' clamping operation which always returns a value between min and max (inclusive).

--- a/src/System/Math.hpp
+++ b/src/System/Math.hpp
@@ -203,7 +203,7 @@ namespace sw
 		// IEEE-754 floating-point numbers are sorted by magnitude in the same way as integers,
 		// except negative values are like one's complement integers. Convert them to two's complement.
 		int32_t i = bit_cast<int32_t>(f);
-		return (i < 0) ? (0x7FFFFFFF - i) : i;
+		return (i < 0) ? (0x7FFFFFFFu - i) : i;
 	}
 	// 'Safe' clamping operation which always returns a value between min and max (inclusive).