Skip to content

S
swiftshader
Commit 646a2770 by Antonio Maiorano Committed by swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com
Options

VulkanBenchmarks: add solid and interpolated triangles tests

Generalized TriangleBenchmark to support rendering a triangle of a solid color (hard-coded in shader), interpolated input colors, and interpolated colors with texture sampling. Added benchmark captures for each type, along with multi-sampled versions of each. Bug: b/176981107 Change-Id: Iadef1f0f9a339038198f8ef0e492c4c2909a96b2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/51889Tested-by: 's avatarAntonio Maiorano <amaiorano@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
parent 413f7cb1
Showing with 123 additions and 13 deletions
tests/VulkanBenchmarks/VulkanBenchmarks.cpp
...@@ -199,11 +199,25 @@ static void ClearImage(benchmark::State &state, vk::Format clearFormat, vk::Imag ...@@ -199,11 +199,25 @@ static void ClearImage(benchmark::State &state, vk::Format clearFormat, vk::Imag
} }
} }
enum class FragShadeType
{
Solid,
Interpolate,
Sample,
};
enum class Multisample
{
False,
True
};
class TriangleBenchmark : public VulkanBenchmark class TriangleBenchmark : public VulkanBenchmark
{ {
public: public:
TriangleBenchmark(bool multisample) TriangleBenchmark(FragShadeType fragShadeType, Multisample multisample)
: multisample(multisample) : fragShadeType(fragShadeType)
, multisample(multisample == Multisample::True)
{ {
window.reset(new Window(instance, windowSize)); window.reset(new Window(instance, windowSize));
swapchain.reset(new Swapchain(physicalDevice, device, *window)); swapchain.reset(new Swapchain(physicalDevice, device, *window));
...@@ -306,6 +320,9 @@ protected: ...@@ -306,6 +320,9 @@ protected:
commandPoolCreateInfo.flags = vk::CommandPoolCreateFlagBits::eResetCommandBuffer; commandPoolCreateInfo.flags = vk::CommandPoolCreateFlagBits::eResetCommandBuffer;
commandPool = device.createCommandPool(commandPoolCreateInfo); commandPool = device.createCommandPool(commandPoolCreateInfo);
std::vector<vk::DescriptorSet> descriptorSets;
if(fragShadeType == FragShadeType::Sample)
{
texture.reset(new Image(device, 16, 16, vk::Format::eR8G8B8A8Unorm)); texture.reset(new Image(device, 16, 16, vk::Format::eR8G8B8A8Unorm));
// Fill texture with white // Fill texture with white
...@@ -351,7 +368,7 @@ protected: ...@@ -351,7 +368,7 @@ protected:
allocInfo.descriptorSetCount = 1; allocInfo.descriptorSetCount = 1;
allocInfo.pSetLayouts = layouts.data(); allocInfo.pSetLayouts = layouts.data();
std::vector<vk::DescriptorSet> descriptorSets = device.allocateDescriptorSets(allocInfo); descriptorSets = device.allocateDescriptorSets(allocInfo);
vk::DescriptorImageInfo imageInfo; vk::DescriptorImageInfo imageInfo;
imageInfo.imageLayout = vk::ImageLayout::eShaderReadOnlyOptimal; imageInfo.imageLayout = vk::ImageLayout::eShaderReadOnlyOptimal;
...@@ -368,6 +385,7 @@ protected: ...@@ -368,6 +385,7 @@ protected:
descriptorWrites[0].pImageInfo = &imageInfo; descriptorWrites[0].pImageInfo = &imageInfo;
device.updateDescriptorSets(static_cast<uint32_t>(descriptorWrites.size()), descriptorWrites.data(), 0, nullptr); device.updateDescriptorSets(static_cast<uint32_t>(descriptorWrites.size()), descriptorWrites.data(), 0, nullptr);
}
vk::CommandBufferAllocateInfo commandBufferAllocateInfo; vk::CommandBufferAllocateInfo commandBufferAllocateInfo;
commandBufferAllocateInfo.commandPool = commandPool; commandBufferAllocateInfo.commandPool = commandPool;
...@@ -401,7 +419,10 @@ protected: ...@@ -401,7 +419,10 @@ protected:
vk::Rect2D scissor(vk::Offset2D(0, 0), windowSize); vk::Rect2D scissor(vk::Offset2D(0, 0), windowSize);
commandBuffers[i].setScissor(0, 1, &scissor); commandBuffers[i].setScissor(0, 1, &scissor);
if(!descriptorSets.empty())
{
commandBuffers[i].bindDescriptorSets(vk::PipelineBindPoint::eGraphics, pipelineLayout, 0, 1, &descriptorSets[0], 0, nullptr); commandBuffers[i].bindDescriptorSets(vk::PipelineBindPoint::eGraphics, pipelineLayout, 0, 1, &descriptorSets[0], 0, nullptr);
}
// Draw a triangle // Draw a triangle
commandBuffers[i].bindPipeline(vk::PipelineBindPoint::eGraphics, pipeline); commandBuffers[i].bindPipeline(vk::PipelineBindPoint::eGraphics, pipeline);
...@@ -449,9 +470,26 @@ protected: ...@@ -449,9 +470,26 @@ protected:
vertices.inputBinding.stride = sizeof(Vertex); vertices.inputBinding.stride = sizeof(Vertex);
vertices.inputBinding.inputRate = vk::VertexInputRate::eVertex; vertices.inputBinding.inputRate = vk::VertexInputRate::eVertex;
switch(fragShadeType)
{
case FragShadeType::Solid:
vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(0, 0, vk::Format::eR32G32B32Sfloat, offsetof(Vertex, position)));
break;
case FragShadeType::Interpolate:
vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(0, 0, vk::Format::eR32G32B32Sfloat, offsetof(Vertex, position)));
vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(1, 0, vk::Format::eR32G32B32Sfloat, offsetof(Vertex, color)));
break;
case FragShadeType::Sample:
vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(0, 0, vk::Format::eR32G32B32Sfloat, offsetof(Vertex, position))); vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(0, 0, vk::Format::eR32G32B32Sfloat, offsetof(Vertex, position)));
vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(1, 0, vk::Format::eR32G32B32Sfloat, offsetof(Vertex, color))); vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(1, 0, vk::Format::eR32G32B32Sfloat, offsetof(Vertex, color)));
vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(2, 0, vk::Format::eR32G32Sfloat, offsetof(Vertex, texCoord))); vertices.inputAttributes.push_back(vk::VertexInputAttributeDescription(2, 0, vk::Format::eR32G32Sfloat, offsetof(Vertex, texCoord)));
break;
default:
assert(false && "Unhandled fragShadeType");
}
vertices.inputState.vertexBindingDescriptionCount = 1; vertices.inputState.vertexBindingDescriptionCount = 1;
vertices.inputState.pVertexBindingDescriptions = &vertices.inputBinding; vertices.inputState.pVertexBindingDescriptions = &vertices.inputBinding;
...@@ -563,6 +601,9 @@ protected: ...@@ -563,6 +601,9 @@ protected:
vk::Pipeline createGraphicsPipeline(vk::RenderPass renderPass) vk::Pipeline createGraphicsPipeline(vk::RenderPass renderPass)
{ {
std::vector<vk::DescriptorSetLayout> setLayouts;
if(fragShadeType == FragShadeType::Sample)
{
vk::DescriptorSetLayoutBinding samplerLayoutBinding; vk::DescriptorSetLayoutBinding samplerLayoutBinding;
samplerLayoutBinding.binding = 1; samplerLayoutBinding.binding = 1;
samplerLayoutBinding.descriptorCount = 1; samplerLayoutBinding.descriptorCount = 1;
...@@ -577,7 +618,8 @@ protected: ...@@ -577,7 +618,8 @@ protected:
descriptorSetLayout = device.createDescriptorSetLayout(layoutInfo); descriptorSetLayout = device.createDescriptorSetLayout(layoutInfo);
std::vector<vk::DescriptorSetLayout> setLayouts(1, descriptorSetLayout); setLayouts.push_back(descriptorSetLayout);
}
vk::PipelineLayoutCreateInfo pipelineLayoutCreateInfo; vk::PipelineLayoutCreateInfo pipelineLayoutCreateInfo;
pipelineLayoutCreateInfo.setLayoutCount = static_cast<uint32_t>(setLayouts.size()); pipelineLayoutCreateInfo.setLayoutCount = static_cast<uint32_t>(setLayouts.size());
...@@ -633,7 +675,64 @@ protected: ...@@ -633,7 +675,64 @@ protected:
multisampleState.rasterizationSamples = multisample ? vk::SampleCountFlagBits::e4 : vk::SampleCountFlagBits::e1; multisampleState.rasterizationSamples = multisample ? vk::SampleCountFlagBits::e4 : vk::SampleCountFlagBits::e1;
multisampleState.pSampleMask = nullptr; multisampleState.pSampleMask = nullptr;
const char *vertexShader = R"(#version 310 es const char *vertexShader = nullptr;
const char *fragmentShader = nullptr;
switch(fragShadeType)
{
case FragShadeType::Solid:
{
vertexShader = R"(#version 310 es
layout(location = 0) in vec3 inPos;
void main()
{
gl_Position = vec4(inPos.xyz, 1.0);
})";
fragmentShader = R"(#version 310 es
precision highp float;
layout(location = 0) out vec4 outColor;
void main()
{
outColor = vec4(1.0, 1.0, 1.0, 1.0);
})";
}
break;
case FragShadeType::Interpolate:
{
vertexShader = R"(#version 310 es
layout(location = 0) in vec3 inPos;
layout(location = 1) in vec3 inColor;
layout(location = 0) out vec3 outColor;
void main()
{
outColor = inColor;
gl_Position = vec4(inPos.xyz, 1.0);
})";
fragmentShader = R"(#version 310 es
precision highp float;
layout(location = 0) in vec3 inColor;
layout(location = 0) out vec4 outColor;
void main()
{
outColor = vec4(inColor, 1.0);
})";
}
break;
case FragShadeType::Sample:
{
vertexShader = R"(#version 310 es
layout(location = 0) in vec3 inPos; layout(location = 0) in vec3 inPos;
layout(location = 1) in vec3 inColor; layout(location = 1) in vec3 inColor;
...@@ -645,10 +744,9 @@ protected: ...@@ -645,10 +744,9 @@ protected:
outColor = inColor; outColor = inColor;
gl_Position = vec4(inPos.xyz, 1.0); gl_Position = vec4(inPos.xyz, 1.0);
fragTexCoord = inPos.xy; fragTexCoord = inPos.xy;
} })";
)";
const char *fragmentShader = R"(#version 310 es fragmentShader = R"(#version 310 es
precision highp float; precision highp float;
layout(location = 0) in vec3 inColor; layout(location = 0) in vec3 inColor;
...@@ -661,8 +759,14 @@ protected: ...@@ -661,8 +759,14 @@ protected:
void main() void main()
{ {
outColor = texture(texSampler, fragTexCoord) * vec4(inColor, 1.0); outColor = texture(texSampler, fragTexCoord) * vec4(inColor, 1.0);
})";
}
break;
default:
assert(false && "Unhandled fragShadeType");
break;
} }
)";
vk::ShaderModule vertexModule = createShaderModule(vertexShader, EShLanguage::EShLangVertex); vk::ShaderModule vertexModule = createShaderModule(vertexShader, EShLanguage::EShLangVertex);
vk::ShaderModule fragmentModule = createShaderModule(fragmentShader, EShLanguage::EShLangFragment); vk::ShaderModule fragmentModule = createShaderModule(fragmentShader, EShLanguage::EShLangFragment);
...@@ -698,6 +802,7 @@ protected: ...@@ -698,6 +802,7 @@ protected:
} }
const vk::Extent2D windowSize = { 1280, 720 }; const vk::Extent2D windowSize = { 1280, 720 };
const FragShadeType fragShadeType;
const bool multisample; const bool multisample;
std::unique_ptr<Window> window; std::unique_ptr<Window> window;
...@@ -732,9 +837,9 @@ protected: ...@@ -732,9 +837,9 @@ protected:
std::vector<vk::CommandBuffer> commandBuffers; // Owning handles std::vector<vk::CommandBuffer> commandBuffers; // Owning handles
}; };
static void Triangle(benchmark::State &state, bool multisample) static void Triangle(benchmark::State &state, FragShadeType fragShadeType, Multisample multisample)
{ {
TriangleBenchmark benchmark(multisample); TriangleBenchmark benchmark(fragShadeType, multisample);
if(false) benchmark.show(); // Enable for visual verification. if(false) benchmark.show(); // Enable for visual verification.
...@@ -750,5 +855,10 @@ static void Triangle(benchmark::State &state, bool multisample) ...@@ -750,5 +855,10 @@ static void Triangle(benchmark::State &state, bool multisample)
BENCHMARK_CAPTURE(ClearImage, VK_FORMAT_R8G8B8A8_UNORM, vk::Format::eR8G8B8A8Unorm, vk::ImageAspectFlagBits::eColor)->Unit(benchmark::kMillisecond); BENCHMARK_CAPTURE(ClearImage, VK_FORMAT_R8G8B8A8_UNORM, vk::Format::eR8G8B8A8Unorm, vk::ImageAspectFlagBits::eColor)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(ClearImage, VK_FORMAT_R32_SFLOAT, vk::Format::eR32Sfloat, vk::ImageAspectFlagBits::eColor)->Unit(benchmark::kMillisecond); BENCHMARK_CAPTURE(ClearImage, VK_FORMAT_R32_SFLOAT, vk::Format::eR32Sfloat, vk::ImageAspectFlagBits::eColor)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(ClearImage, VK_FORMAT_D32_SFLOAT, vk::Format::eD32Sfloat, vk::ImageAspectFlagBits::eDepth)->Unit(benchmark::kMillisecond); BENCHMARK_CAPTURE(ClearImage, VK_FORMAT_D32_SFLOAT, vk::Format::eD32Sfloat, vk::ImageAspectFlagBits::eDepth)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(Triangle, Hello, false)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(Triangle, Multisample, true)->Unit(benchmark::kMillisecond); BENCHMARK_CAPTURE(Triangle, Solid, FragShadeType::Solid, Multisample::False)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(Triangle, Interpolate, FragShadeType::Interpolate, Multisample::False)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(Triangle, Sample, FragShadeType::Sample, Multisample::False)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(Triangle, Solid_Multisample, FragShadeType::Solid, Multisample::True)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(Triangle, Interpolate_Multisample, FragShadeType::Interpolate, Multisample::True)->Unit(benchmark::kMillisecond);
BENCHMARK_CAPTURE(Triangle, Sample_Multisample, FragShadeType::Sample, Multisample::True)->Unit(benchmark::kMillisecond);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment