Add CMake flag to treat warnings as errors

Disabled by default by the request of Nicolas. Bug: b/123933266 Change-Id: Ie1217dc6c96ec85c9daf8246de785c8729386634 Reviewed-on: https://swiftshader-review.googlesource.com/c/25015Tested-by: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com>

Add CMake flag to treat warnings as errors
7aafb274 · Ben Clayton · Ben Clayton · b607bc88 · 7aafb274 · 7aafb274
Commit 7aafb274 authored Feb 19, 2019 by Ben Clayton Committed by Ben Clayton Feb 22, 2019
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

tasks.json .vscode/tasks.json +2 -1

CMakeLists.txt CMakeLists.txt +5 -0

No files found.
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -66,7 +66,8 @@
            "command": "cmake",
            "args": [
                "..",
-                "-DCMAKE_BUILD_TYPE=${input:buildType}"
+                "-DCMAKE_BUILD_TYPE=${input:buildType}",
+                "-DWARNINGS_AS_ERRORS=1"
            ],
            "options": {
                "cwd": "${workspaceRoot}/build"

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -76,6 +76,7 @@ option (MSAN "Build with memory sanitizer" 0)
 option (ASAN "Build with address sanitizer" 0)
 option (TSAN "Build with thread sanitizer" 0)
 option (UBSAN "Build with undefined behavior sanitizer" 0)
+option (WARNINGS_AS_ERRORS "Treat all warnings as errors" 0)
 if(ARCH STREQUAL "arm")
    set(DEFAULT_REACTOR_BACKEND "Subzero")
@@ -266,6 +267,10 @@ else()
        set_cpp_flag("-s" RELEASE)
    endif()
+    if(WARNINGS_AS_ERRORS)
+        set_cpp_flag("-Werror") # Treat all warnings as errors
+    endif()
    # Disable pedanitc warnings
    if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
        set_cpp_flag("-Wno-ignored-attributes") # ignoring attributes on template argument 'X'