Skip to content

S
swiftshader
Commit 85bd613c by Alexis Hetu Committed by Alexis Hétu
Options

Intentionally ignore pipeline cache for now

Since PipelineCache is a potential optimization, unmarking it as UNIMPLEMENTED() and leaving a TODO instead. This can be addressed much later, but for now, this shouldn't make tests fail. Bug b/118386749 b/123588002 Change-Id: I5bdc15aedd9a01e35a457eef1a70c450083fd577 Reviewed-on: https://swiftshader-review.googlesource.com/c/23969Tested-by: 's avatarAlexis Hétu <sugoi@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent ec061ddc
Showing with 2 additions and 8 deletions
src/Vulkan/libVulkan.cpp
...@@ -930,10 +930,7 @@ VKAPI_ATTR VkResult VKAPI_CALL vkCreateGraphicsPipelines(VkDevice device, VkPipe ...@@ -930,10 +930,7 @@ VKAPI_ATTR VkResult VKAPI_CALL vkCreateGraphicsPipelines(VkDevice device, VkPipe
TRACE("(VkDevice device = 0x%X, VkPipelineCache pipelineCache = 0x%X, uint32_t createInfoCount = %d, const VkGraphicsPipelineCreateInfo* pCreateInfos, const VkAllocationCallbacks* pAllocator = 0x%X, VkPipeline* pPipelines = 0x%X)", TRACE("(VkDevice device = 0x%X, VkPipelineCache pipelineCache = 0x%X, uint32_t createInfoCount = %d, const VkGraphicsPipelineCreateInfo* pCreateInfos, const VkAllocationCallbacks* pAllocator = 0x%X, VkPipeline* pPipelines = 0x%X)",
device, pipelineCache, createInfoCount, pCreateInfos, pAllocator, pPipelines); device, pipelineCache, createInfoCount, pCreateInfos, pAllocator, pPipelines);
if(pipelineCache != VK_NULL_HANDLE) // TODO (b/123588002): Optimize based on pipelineCache.
{
UNIMPLEMENTED();
}
VkResult errorResult = VK_SUCCESS; VkResult errorResult = VK_SUCCESS;
for(uint32_t i = 0; i < createInfoCount; i++) for(uint32_t i = 0; i < createInfoCount; i++)
...@@ -966,10 +963,7 @@ VKAPI_ATTR VkResult VKAPI_CALL vkCreateComputePipelines(VkDevice device, VkPipel ...@@ -966,10 +963,7 @@ VKAPI_ATTR VkResult VKAPI_CALL vkCreateComputePipelines(VkDevice device, VkPipel
TRACE("(VkDevice device = 0x%X, VkPipelineCache pipelineCache = 0x%X, uint32_t createInfoCount = %d, const VkComputePipelineCreateInfo* pCreateInfos, const VkAllocationCallbacks* pAllocator = 0x%X, VkPipeline* pPipelines = 0x%X)", TRACE("(VkDevice device = 0x%X, VkPipelineCache pipelineCache = 0x%X, uint32_t createInfoCount = %d, const VkComputePipelineCreateInfo* pCreateInfos, const VkAllocationCallbacks* pAllocator = 0x%X, VkPipeline* pPipelines = 0x%X)",
device, pipelineCache, createInfoCount, pCreateInfos, pAllocator, pPipelines); device, pipelineCache, createInfoCount, pCreateInfos, pAllocator, pPipelines);
if(pipelineCache != VK_NULL_HANDLE) // TODO (b/123588002): Optimize based on pipelineCache.
{
UNIMPLEMENTED();
}
VkResult errorResult = VK_SUCCESS; VkResult errorResult = VK_SUCCESS;
for(uint32_t i = 0; i < createInfoCount; i++) for(uint32_t i = 0; i < createInfoCount; i++)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment