CMakeLists: Don't explicitly cherry-pick warnings as errors.

We the WARNINGS_AS_ERRORS CMake flag to treat all warnings as errors. This change demotes the cherry-picked warnings-as-errors to just regular warnings, which can be optionally treated as errors like every other warning (WARNINGS_AS_ERRORS defaults to enabled). Based on the discussions: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29810/6#message-de0432365b25c83372bac2f6528c79174aef0f6b and https://swiftshader-review.googlesource.com/c/SwiftShader/+/30191/2/CMakeLists.txt#248 Bug: b/135472272 Change-Id: I8aa37d79b9263560f9ff55ad4817f66ded6960ee Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32953 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by: Ben Clayton <bclayton@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

CMakeLists: Don't explicitly cherry-pick warnings as errors.
8a983f79 · Ben Clayton · 9b4b63bf · 8a983f79
Commit 8a983f79 authored Jun 18, 2019 by Ben Clayton
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 7 deletions

CMakeLists.txt CMakeLists.txt +7 -7

No files found.
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -333,17 +333,17 @@ else()
    list(APPEND SWIFTSHADER_COMPILE_OPTIONS
        "-Wall"
-        "-Werror=reorder"
+        "-Wreorder"
-        "-Werror=sign-compare"
+        "-Wsign-compare"
-        "-Werror=missing-braces"
+        "-Wmissing-braces"
    )
    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
        list(APPEND SWIFTSHADER_COMPILE_OPTIONS
-            "-Werror=unused-lambda-capture"
+            "-Wunused-lambda-capture"
-            "-Werror=string-conversion"
+            "-Wstring-conversion"
-            "-Werror=extra-semi"
+            "-Wextra-semi"
-            "-Werror=ignored-qualifiers"
+            "-Wignored-qualifiers"
            # Silence errors caused by unknown warnings when building with older
            # versions of Clang. This demands checking that warnings added above
            # are spelled correctly and work as intended!