Skip to content

S
swiftshader
Commit ab3c36b9 by Chris Forbes
Options

Remove asserts blocking atomic load/store in Image storage class

Test: dEQP-VK.memory_model.* Bug: b/127472316 Change-Id: I96447aba539e2ae9b4d42637fbe4a829f35093f5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31513Tested-by: 's avatarChris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent d47ca872
Showing with 0 additions and 10 deletions
src/Pipeline/SpirvShader.cpp
...@@ -2675,11 +2675,6 @@ namespace sw ...@@ -2675,11 +2675,6 @@ namespace sw
memoryOrder = MemoryOrder(memorySemantics); memoryOrder = MemoryOrder(memorySemantics);
} }
if (pointerTy.storageClass == spv::StorageClassImage)
{
UNIMPLEMENTED("StorageClassImage load not yet implemented");
}
auto ptr = GetPointerToData(pointerId, 0, routine); auto ptr = GetPointerToData(pointerId, 0, routine);
bool interleavedByLane = IsStorageInterleavedByLane(pointerTy.storageClass); bool interleavedByLane = IsStorageInterleavedByLane(pointerTy.storageClass);
...@@ -2717,11 +2712,6 @@ namespace sw ...@@ -2717,11 +2712,6 @@ namespace sw
ASSERT(!atomic || elementTy.opcode() == spv::OpTypeInt); // Vulkan 1.1: "Atomic instructions must declare a scalar 32-bit integer type, for the value pointed to by Pointer." ASSERT(!atomic || elementTy.opcode() == spv::OpTypeInt); // Vulkan 1.1: "Atomic instructions must declare a scalar 32-bit integer type, for the value pointed to by Pointer."
if (pointerTy.storageClass == spv::StorageClassImage)
{
UNIMPLEMENTED("StorageClassImage store not yet implemented");
}
auto ptr = GetPointerToData(pointerId, 0, routine); auto ptr = GetPointerToData(pointerId, 0, routine);
bool interleavedByLane = IsStorageInterleavedByLane(pointerTy.storageClass); bool interleavedByLane = IsStorageInterleavedByLane(pointerTy.storageClass);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment