Commit cbb1d3d7 by Karl Schimpf

Clean up unit munging unit tests using common NaCl API.

Simplify the munging unit tests to follow the new NaCl utilities for munging tests. Note that this CL takes advantage of changes added by CL https://codereview.chromium.org/1140153004 BUG=None R=stichnot@chromium.org Review URL: https://codereview.chromium.org/1149423011
parent 8af4aac7
...@@ -259,6 +259,7 @@ $(UNITTEST_OBJS): $(OBJDIR)/unittest/%.o: unittest/%.cpp \ ...@@ -259,6 +259,7 @@ $(UNITTEST_OBJS): $(OBJDIR)/unittest/%.o: unittest/%.cpp \
$(CXX) -c $(CXXFLAGS) \ $(CXX) -c $(CXXFLAGS) \
-Isrc/ \ -Isrc/ \
-I$(LLVM_SRC_PATH)/utils/unittest/googletest/include \ -I$(LLVM_SRC_PATH)/utils/unittest/googletest/include \
-I$(LLVM_SRC_PATH) \
-DGTEST_HAS_RTTI=0 -DGTEST_USE_OWN_TR1_TUPLE \ -DGTEST_HAS_RTTI=0 -DGTEST_USE_OWN_TR1_TUPLE \
$< -o $@ $< -o $@
......
...@@ -33,14 +33,14 @@ void IceTest::SubzeroBitcodeMunger::resetMungeFlags() { ...@@ -33,14 +33,14 @@ void IceTest::SubzeroBitcodeMunger::resetMungeFlags() {
Flags.setVerbose(Ice::IceV_Instructions); Flags.setVerbose(Ice::IceV_Instructions);
} }
bool IceTest::SubzeroBitcodeMunger::runTest(const char *TestName, bool IceTest::SubzeroBitcodeMunger::runTest(const uint64_t Munges[],
const uint64_t Munges[],
size_t MungeSize) { size_t MungeSize) {
const bool AddHeader = true; const bool AddHeader = true;
setupTest(TestName, Munges, MungeSize, AddHeader); setupTest(Munges, MungeSize, AddHeader);
Ice::GlobalContext Ctx(DumpStream, DumpStream, DumpStream, nullptr, Flags); Ice::GlobalContext Ctx(DumpStream, DumpStream, DumpStream, nullptr, Flags);
Ice::PNaClTranslator Translator(&Ctx); Ice::PNaClTranslator Translator(&Ctx);
Translator.translateBuffer(TestName, MungedInput.get()); const char *BufferName = "Test";
Translator.translateBuffer(BufferName, MungedInput.get());
cleanupTest(); cleanupTest();
return Translator.getErrorStatus().value() == 0; return Translator.getErrorStatus().value() == 0;
......
...@@ -36,12 +36,12 @@ public: ...@@ -36,12 +36,12 @@ public:
/// Runs PNaClTranslator to translate bitcode records (with defined /// Runs PNaClTranslator to translate bitcode records (with defined
/// record Munges), and puts output into DumpResults. Returns true /// record Munges), and puts output into DumpResults. Returns true
/// if parse is successful. /// if parse is successful.
bool runTest(const char *TestName, const uint64_t Munges[], size_t MungeSize); bool runTest(const uint64_t Munges[], size_t MungeSize);
/// Same as above, but without any edits. /// Same as above, but without any edits.
bool runTest(const char *TestName) { bool runTest() {
uint64_t NoMunges[] = {0}; uint64_t NoMunges[] = {0};
return runTest(TestName, NoMunges, 0); return runTest(NoMunges, 0);
} }
/// Sets flags back to default assumptions for munging. /// Sets flags back to default assumptions for munging.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment