Skip to content

S
swiftshader
Commit d5317120 by Ben Clayton Committed by Ben Clayton
Options

Silence warnings: Add default cases to partial enum switches.

Fixes warnings about switch statements not handling all enum values. Bug: b/123933266 Change-Id: I0372ebf2412452622eb99ea7bba7ebc5cedd385c Reviewed-on: https://swiftshader-review.googlesource.com/c/25009Tested-by: 's avatarBen Clayton <bclayton@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
parent 7f8fa973
Showing with 16 additions and 0 deletions
src/Vulkan/VkImageView.cpp
...@@ -45,6 +45,8 @@ bool ImageView::imageTypesMatch(VkImageType imageType) const ...@@ -45,6 +45,8 @@ bool ImageView::imageTypesMatch(VkImageType imageType) const
case VK_IMAGE_VIEW_TYPE_1D: case VK_IMAGE_VIEW_TYPE_1D:
case VK_IMAGE_VIEW_TYPE_1D_ARRAY: case VK_IMAGE_VIEW_TYPE_1D_ARRAY:
return true; return true;
default:
break;
} }
break; break;
case VK_IMAGE_TYPE_2D: case VK_IMAGE_TYPE_2D:
...@@ -56,6 +58,8 @@ bool ImageView::imageTypesMatch(VkImageType imageType) const ...@@ -56,6 +58,8 @@ bool ImageView::imageTypesMatch(VkImageType imageType) const
case VK_IMAGE_VIEW_TYPE_CUBE: case VK_IMAGE_VIEW_TYPE_CUBE:
case VK_IMAGE_VIEW_TYPE_CUBE_ARRAY: case VK_IMAGE_VIEW_TYPE_CUBE_ARRAY:
return isCube; return isCube;
default:
break;
} }
break; break;
case VK_IMAGE_TYPE_3D: case VK_IMAGE_TYPE_3D:
...@@ -63,6 +67,8 @@ bool ImageView::imageTypesMatch(VkImageType imageType) const ...@@ -63,6 +67,8 @@ bool ImageView::imageTypesMatch(VkImageType imageType) const
{ {
case VK_IMAGE_VIEW_TYPE_3D: case VK_IMAGE_VIEW_TYPE_3D:
return true; return true;
default:
break;
} }
break; break;
default: default:
......
src/Vulkan/VkPhysicalDevice.cpp
...@@ -403,6 +403,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF ...@@ -403,6 +403,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF
pFormatProperties->optimalTilingFeatures |= pFormatProperties->optimalTilingFeatures |=
VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT; VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT;
break; break;
default:
break;
} }
switch(format) switch(format)
...@@ -438,6 +440,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF ...@@ -438,6 +440,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF
pFormatProperties->bufferFeatures |= pFormatProperties->bufferFeatures |=
VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT; VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT;
break; break;
default:
break;
} }
switch(format) switch(format)
...@@ -493,6 +497,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF ...@@ -493,6 +497,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF
pFormatProperties->optimalTilingFeatures |= pFormatProperties->optimalTilingFeatures |=
VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT; VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT;
break; break;
default:
break;
} }
switch(format) switch(format)
...@@ -545,6 +551,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF ...@@ -545,6 +551,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF
pFormatProperties->bufferFeatures |= pFormatProperties->bufferFeatures |=
VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT; VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT;
break; break;
default:
break;
} }
switch(format) switch(format)
...@@ -590,6 +598,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF ...@@ -590,6 +598,8 @@ void PhysicalDevice::getFormatProperties(VkFormat format, VkFormatProperties* pF
pFormatProperties->bufferFeatures |= pFormatProperties->bufferFeatures |=
VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT; VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT;
break; break;
default:
break;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment