Advertise VK_PRESENT_MODE_MAILBOX_KHR

This is required by vkmark and various other workloads. The present mode handling is not really correct -- both our fifo and mailbox modes behave more like IMMEDIATE due to XPutImage etc being completely unthrottled Future changes will introduce proper present mode handling for the Xlib and Xcb WSI implementations. Bug: b/124265819 Change-Id: Ia71ff928848be9925ffb30a27fe6c35732b68590 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39288 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Chris Forbes <chrisforbes@google.com>

Advertise VK_PRESENT_MODE_MAILBOX_KHR
f466eb51 · Chris Forbes · c7a09685 · f466eb51
Commit f466eb51 authored Dec 10, 2019 by Chris Forbes
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

VkSurfaceKHR.cpp src/WSI/VkSurfaceKHR.cpp +6 -0

No files found.
--- a/src/WSI/VkSurfaceKHR.cpp
+++ b/src/WSI/VkSurfaceKHR.cpp
@@ -29,7 +29,13 @@ static const VkSurfaceFormatKHR surfaceFormats[] =
 static const VkPresentModeKHR presentModes[] =
 {
+	// FIXME(b/124265819): Make present modes behave correctly. Currently we use XPutImage
+	// with no synchronization, which behaves more like VK_PRESENT_MODE_IMMEDIATE_KHR. We
+	// should convert to using the Present extension, which allows us to request presentation
+	// at particular msc values. Will need a similar solution on Windows - possibly interact
+	// with DXGI directly.
 	VK_PRESENT_MODE_FIFO_KHR,
+	VK_PRESENT_MODE_MAILBOX_KHR,
 };
 }