Skip to content

S
swiftshader
Commit f5d8e097 by Srdjan Obucina Committed by Jim Stichnoth
Options

Subzero, MIPS32: Remove duplicate functionalities

Removes lowering functions functionalities already covered by genTargetHelperCallFor. Adds error messages for appropriate cases. R=stichnot@chromium.org Review URL: https://codereview.chromium.org/2358123002 . Patch from Srdjan Obucina <Srdjan.Obucina@imgtec.com>.
parent d895447b
Showing with 52 additions and 41 deletions
src/IceTargetLoweringMIPS32.cpp
...@@ -1839,15 +1839,6 @@ void TargetMIPS32::lowerArithmetic(const InstArithmetic *Instr) { ...@@ -1839,15 +1839,6 @@ void TargetMIPS32::lowerArithmetic(const InstArithmetic *Instr) {
UnimplementedLoweringError(this, Instr); UnimplementedLoweringError(this, Instr);
return; return;
} }
switch (Instr->getOp()) {
default:
break;
case InstArithmetic::Frem:
UnimplementedLoweringError(this, Instr);
return;
}
// At this point Dest->getType() is non-i64 scalar
Variable *T = makeReg(Dest->getType()); Variable *T = makeReg(Dest->getType());
Variable *Src0R = legalizeToReg(Src0); Variable *Src0R = legalizeToReg(Src0);
...@@ -1979,6 +1970,7 @@ void TargetMIPS32::lowerArithmetic(const InstArithmetic *Instr) { ...@@ -1979,6 +1970,7 @@ void TargetMIPS32::lowerArithmetic(const InstArithmetic *Instr) {
} }
break; break;
case InstArithmetic::Frem: case InstArithmetic::Frem:
llvm::report_fatal_error("frem should have been prelowered.");
break; break;
} }
UnimplementedLoweringError(this, Instr); UnimplementedLoweringError(this, Instr);
...@@ -2415,6 +2407,10 @@ void TargetMIPS32::lowerCast(const InstCast *Instr) { ...@@ -2415,6 +2407,10 @@ void TargetMIPS32::lowerCast(const InstCast *Instr) {
break; break;
} }
case InstCast::Fptosi: { case InstCast::Fptosi: {
if (llvm::isa<Variable64On32>(Dest)) {
llvm::report_fatal_error("fp-to-i64 should have been prelowered.");
return;
}
if (Src0Ty == IceType_f32 && DestTy == IceType_i32) { if (Src0Ty == IceType_f32 && DestTy == IceType_i32) {
Variable *Src0R = legalizeToReg(Src0); Variable *Src0R = legalizeToReg(Src0);
Variable *FTmp = makeReg(IceType_f32); Variable *FTmp = makeReg(IceType_f32);
...@@ -2426,9 +2422,17 @@ void TargetMIPS32::lowerCast(const InstCast *Instr) { ...@@ -2426,9 +2422,17 @@ void TargetMIPS32::lowerCast(const InstCast *Instr) {
break; break;
} }
case InstCast::Fptoui: case InstCast::Fptoui:
if (llvm::isa<Variable64On32>(Dest)) {
llvm::report_fatal_error("fp-to-i64 should have been prelowered.");
return;
}
UnimplementedLoweringError(this, Instr); UnimplementedLoweringError(this, Instr);
break; break;
case InstCast::Sitofp: { case InstCast::Sitofp: {
if (llvm::isa<Variable64On32>(Dest)) {
llvm::report_fatal_error("i64-to-fp should have been prelowered.");
return;
}
if (Src0Ty == IceType_i32 && DestTy == IceType_f32) { if (Src0Ty == IceType_i32 && DestTy == IceType_f32) {
Variable *Src0R = legalizeToReg(Src0); Variable *Src0R = legalizeToReg(Src0);
Variable *FTmp1 = makeReg(IceType_f32); Variable *FTmp1 = makeReg(IceType_f32);
...@@ -2442,11 +2446,44 @@ void TargetMIPS32::lowerCast(const InstCast *Instr) { ...@@ -2442,11 +2446,44 @@ void TargetMIPS32::lowerCast(const InstCast *Instr) {
break; break;
} }
case InstCast::Uitofp: { case InstCast::Uitofp: {
if (llvm::isa<Variable64On32>(Dest)) {
llvm::report_fatal_error("i64-to-fp should have been prelowered.");
return;
}
UnimplementedLoweringError(this, Instr); UnimplementedLoweringError(this, Instr);
break; break;
} }
case InstCast::Bitcast: { case InstCast::Bitcast: {
switch (DestTy) {
case IceType_NUM:
case IceType_void:
llvm::report_fatal_error("Unexpected bitcast.");
case IceType_i1:
UnimplementedLoweringError(this, Instr);
break;
case IceType_i8:
assert(Src0->getType() == IceType_v8i1);
llvm::report_fatal_error(
"i8 to v8i1 conversion should have been prelowered.");
break;
case IceType_i16:
assert(Src0->getType() == IceType_v16i1);
llvm::report_fatal_error(
"i16 to v16i1 conversion should have been prelowered.");
break;
case IceType_v8i1:
assert(Src0->getType() == IceType_i8);
llvm::report_fatal_error(
"v8i1 to i8 conversion should have been prelowered.");
break;
case IceType_v16i1:
assert(Src0->getType() == IceType_i16);
llvm::report_fatal_error(
"v16i1 to i16 conversion should have been prelowered.");
break;
default:
UnimplementedLoweringError(this, Instr); UnimplementedLoweringError(this, Instr);
}
break; break;
} }
} }
...@@ -2805,7 +2842,7 @@ void TargetMIPS32::lowerIntrinsicCall(const InstIntrinsicCall *Instr) { ...@@ -2805,7 +2842,7 @@ void TargetMIPS32::lowerIntrinsicCall(const InstIntrinsicCall *Instr) {
return; return;
} }
case Intrinsics::Ctpop: { case Intrinsics::Ctpop: {
UnimplementedLoweringError(this, Instr); llvm::report_fatal_error("Ctpop should have been prelowered.");
return; return;
} }
case Intrinsics::Ctlz: { case Intrinsics::Ctlz: {
...@@ -2829,42 +2866,19 @@ void TargetMIPS32::lowerIntrinsicCall(const InstIntrinsicCall *Instr) { ...@@ -2829,42 +2866,19 @@ void TargetMIPS32::lowerIntrinsicCall(const InstIntrinsicCall *Instr) {
return; return;
} }
case Intrinsics::Longjmp: { case Intrinsics::Longjmp: {
InstCall *Call = makeHelperCall(RuntimeHelper::H_call_longjmp, nullptr, 2); llvm::report_fatal_error("longjmp should have been prelowered.");
Call->addArg(Instr->getArg(0));
Call->addArg(Instr->getArg(1));
lowerCall(Call);
return; return;
} }
case Intrinsics::Memcpy: { case Intrinsics::Memcpy: {
// In the future, we could potentially emit an inline memcpy/memset, etc. llvm::report_fatal_error("memcpy should have been prelowered.");
// for intrinsic calls w/ a known length.
InstCall *Call = makeHelperCall(RuntimeHelper::H_call_memcpy, nullptr, 3);
Call->addArg(Instr->getArg(0));
Call->addArg(Instr->getArg(1));
Call->addArg(Instr->getArg(2));
lowerCall(Call);
return; return;
} }
case Intrinsics::Memmove: { case Intrinsics::Memmove: {
InstCall *Call = makeHelperCall(RuntimeHelper::H_call_memmove, nullptr, 3); llvm::report_fatal_error("memmove should have been prelowered.");
Call->addArg(Instr->getArg(0));
Call->addArg(Instr->getArg(1));
Call->addArg(Instr->getArg(2));
lowerCall(Call);
return; return;
} }
case Intrinsics::Memset: { case Intrinsics::Memset: {
// The value operand needs to be extended to a stack slot size because the llvm::report_fatal_error("memset should have been prelowered.");
// PNaCl ABI requires arguments to be at least 32 bits wide.
Operand *ValOp = Instr->getArg(1);
assert(ValOp->getType() == IceType_i8);
Variable *ValExt = Func->makeVariable(stackSlotType());
lowerCast(InstCast::create(Func, InstCast::Zext, ValExt, ValOp));
InstCall *Call = makeHelperCall(RuntimeHelper::H_call_memset, nullptr, 3);
Call->addArg(Instr->getArg(0));
Call->addArg(ValExt);
Call->addArg(Instr->getArg(2));
lowerCall(Call);
return; return;
} }
case Intrinsics::NaClReadTP: { case Intrinsics::NaClReadTP: {
...@@ -2878,10 +2892,7 @@ void TargetMIPS32::lowerIntrinsicCall(const InstIntrinsicCall *Instr) { ...@@ -2878,10 +2892,7 @@ void TargetMIPS32::lowerIntrinsicCall(const InstIntrinsicCall *Instr) {
return; return;
} }
case Intrinsics::Setjmp: { case Intrinsics::Setjmp: {
InstCall *Call = llvm::report_fatal_error("setjmp should have been prelowered.");
makeHelperCall(RuntimeHelper::H_call_setjmp, Instr->getDest(), 1);
Call->addArg(Instr->getArg(0));
lowerCall(Call);
return; return;
} }
case Intrinsics::Sqrt: { case Intrinsics::Sqrt: {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment