Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
S
swiftshader
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
swiftshader
Commits
fc707ffe
Commit
fc707ffe
authored
Feb 29, 2016
by
Sean Klein
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix clang warning "has virtual functions but non-virtual destructor".
BUG= None R=stichnot@chromium.org Review URL:
https://codereview.chromium.org/1741733003
.
parent
e641e92c
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
3 deletions
+4
-3
IceAssembler.h
src/IceAssembler.h
+1
-1
IceFixups.h
src/IceFixups.h
+1
-0
IceInst.h
src/IceInst.h
+1
-1
IceOperand.h
src/IceOperand.h
+1
-1
No files found.
src/IceAssembler.h
View file @
fc707ffe
...
@@ -46,7 +46,7 @@ class Label {
...
@@ -46,7 +46,7 @@ class Label {
public
:
public
:
Label
()
=
default
;
Label
()
=
default
;
~
Label
()
=
default
;
virtual
~
Label
()
=
default
;
virtual
void
finalCheck
()
const
{
virtual
void
finalCheck
()
const
{
// Assert if label is being destroyed with unresolved branches pending.
// Assert if label is being destroyed with unresolved branches pending.
...
...
src/IceFixups.h
View file @
fc707ffe
...
@@ -31,6 +31,7 @@ class AssemblerFixup {
...
@@ -31,6 +31,7 @@ class AssemblerFixup {
public
:
public
:
AssemblerFixup
()
=
default
;
AssemblerFixup
()
=
default
;
AssemblerFixup
(
const
AssemblerFixup
&
)
=
default
;
AssemblerFixup
(
const
AssemblerFixup
&
)
=
default
;
virtual
~
AssemblerFixup
()
=
default
;
intptr_t
position
()
const
{
intptr_t
position
()
const
{
assert
(
position_was_set_
);
assert
(
position_was_set_
);
return
position_
;
return
position_
;
...
...
src/IceInst.h
View file @
fc707ffe
...
@@ -165,7 +165,7 @@ public:
...
@@ -165,7 +165,7 @@ public:
void
dumpDest
(
const
Cfg
*
Func
)
const
;
void
dumpDest
(
const
Cfg
*
Func
)
const
;
virtual
bool
isRedundantAssign
()
const
{
return
false
;
}
virtual
bool
isRedundantAssign
()
const
{
return
false
;
}
~
Inst
()
=
default
;
virtual
~
Inst
()
=
default
;
protected
:
protected
:
Inst
(
Cfg
*
Func
,
InstKind
Kind
,
SizeT
MaxSrcs
,
Variable
*
Dest
);
Inst
(
Cfg
*
Func
,
InstKind
Kind
,
SizeT
MaxSrcs
,
Variable
*
Dest
);
...
...
src/IceOperand.h
View file @
fc707ffe
...
@@ -91,7 +91,7 @@ public:
...
@@ -91,7 +91,7 @@ public:
}
}
/// @}
/// @}
~
Operand
()
=
default
;
virtual
~
Operand
()
=
default
;
protected
:
protected
:
Operand
(
OperandKind
Kind
,
Type
Ty
)
:
Ty
(
Ty
),
Kind
(
Kind
)
{
Operand
(
OperandKind
Kind
,
Type
Ty
)
:
Ty
(
Ty
),
Kind
(
Kind
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment