Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • SymbolTable.h
Find file
BlameHistoryPermalink
  • Gus Fernandez's avatar
    Fix a crash with the WebGL conformance test suite. · 964df49d
    Gus Fernandez authored Oct 13, 2014
    Undefined behavior caused by an overflowed enum was causing
    the translator symbol table stack to not get popped correctly
    when the compiler completed, causing dangling symbols who's storage
    was reclaimed and reused when the allocation pool was popped.
    The error occurred in the "shader-with-reserved-words" test, which
    passes when the compiler fails due to the use of reserved words as
    identifiers. As such, this test would pass even if the GPU process
    crashes but further tests in the test suite would fail.
    
    BUG=angle::785, 786
    
    Change-Id: I365cb55f962f8dfe409f40532effeb10b8189432
    Reviewed-on: https://chromium-review.googlesource.com/223093Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org>
    Reviewed-by: 's avatarNicolas Capens <capn@chromium.org>
    Tested-by: 's avatarGus Fernandez <gusfernandez@chromium.org>
    964df49d
SymbolTable.h 10.4 KB
EditWeb IDE
×

Replace SymbolTable.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.