Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler.gypi
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Remove RemoveAllTreeNodes, since it was a no-op · 352beffc
    Olli Etuaho authored Nov 19, 2014
    IntermNode operator delete() or any of the IntermNode destructors don't
    do anything, since all the AST memory is allocated on the PoolAllocator.
    Because of this, RemoveAllTreeNodes was simply a no-op, and redundant
    with the PoolAllocator deallocation procedure, and could confuse people
    reading the code to think that IntermNodes should be deleted
    individually, when in fact this is not the case.
    
    BUG=angle:831
    
    Change-Id: Ie1ccaa51986aabf267280d92a8e76ca9f97a19e5
    Reviewed-on: https://chromium-review.googlesource.com/230730Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    352beffc
compiler.gypi 13 KB
EditWeb IDE
×

Replace compiler.gypi

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.