Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • Intermediate.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Refactor ternary operator parsing · 5290174b
    Olli Etuaho authored Apr 15, 2015
    Refactor ternary operator parsing so that validation is done in
    ParseContext and Intermediate's role is simply to create the node added
    to the tree.
    
    Remove partially bugged checks for null nodes as a part of this - in
    error cases the parser doesn't typically add null nodes to the tree, but
    rather always has a fallback to add a dummy node if parsing fails as a
    method of recovery. When parsing ternary operators it should be
    guaranteed that none of the parameter nodes is null.
    
    Includes a better explanation of why ternary operators are not always
    folded when only the condition is constant, and a test to make sure this
    doesn't regress.
    
    BUG=angleproject:952
    TEST=WebGL conformance tests, angle_unittests
    
    Change-Id: Icbcb721b5ab36cf314a16e79f9814aef1f355fa0
    Reviewed-on: https://chromium-review.googlesource.com/265643Reviewed-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    5290174b
Intermediate.cpp 11.6 KB
EditWeb IDE
×

Replace Intermediate.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.