Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • util
  • Timer.h
Find file
BlameHistoryPermalink
  • Nico Weber's avatar
    Give Timer a virtual destructor as it's deleted polymorphically. · 51a1db16
    Nico Weber authored Apr 06, 2015
    Found by clang:
    
    ..\..\third_party\angle\src\common/angleutils.h(66,5) :  error: delete called on 'Timer' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
        delete resource;
        ^
    ..\..\third_party\angle\src\tests\perf_tests\ANGLEPerfTest.cpp(26,5) :  note: in instantiation of function template specialization 'SafeDelete<Timer>' requested here
        SafeDelete(mTimer);
        ^
    
    BUG=chromium:82385
    
    Change-Id: I69033b1802b5dffbdf2d80889aca7019d710d481
    Reviewed-on: https://chromium-review.googlesource.com/264061Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Tested-by: 's avatarGeoff Lang <geofflang@chromium.org>
    51a1db16
Timer.h 449 Bytes
EditWeb IDE
×

Replace Timer.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.